Sergey Gotliv has posted comments on this change. Change subject: engine: Remove javadoc from one of DiskValidator APIs ......................................................................
Patch Set 3: (3 comments) See my comments inside the code. I am not against javadocs in general, but this one has wrong signature and the API name speaks on its behave. http://gerrit.ovirt.org/#/c/23952/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java: Line 111 Line 112 Line 113 Line 114 Line 115 The API name is 'isDiskInterfaceSupported' and this javadoc proposes exactly the same, so why its needed? More than that the signature doesn't match so again what is the point of this javadoc?! Line 114 Line 115 Line 116 Line 117 Line 118 Method doesn't receive 'osId'. Line 116 Line 117 Line 118 Line 119 Line 120 Method doesn't receive 'version'. -- To view, visit http://gerrit.ovirt.org/23952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa3d1173400be9eae7f0ba79344fdeb9724ca6d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
