Alexander Wels has uploaded a new change for review.
Change subject: webadmin: Fix issues with splitter tabs
......................................................................
webadmin: Fix issues with splitter tabs
- Fixed issue where if the system tree was minimized the
tab to expand would cover the 'new' button of the active
main tab.
- Fixed issue where the tab of the splitter would show on
top of a dialog if the dialog was dragged over it.
Change-Id: I151fc3a76d9c6f55e265688fbecf965326774497
Signed-off-by: Alexander Wels <aw...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml
M
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabbedSplitLayout.css
3 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/85/24085/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java
index 14add5b..d5d89b1 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java
@@ -86,6 +86,12 @@
private static final String GWT_PREFIX = "gwt-"; //$NON-NLS-1$
private static final String MIN_WIDTH = "minWidth"; //$NON-NLS-1$
private static final String MAX_WIDTH = "maxWidth"; //$NON-NLS-1$
+ /**
+ * The padding to the left of each action button bar, if you change this
value also change the value of the
+ * left-padding in the actionPadding class in SimpleActionTable.ui.xml.
+ */
+ private static final int ACTION_PANEL_PADDING_LEFT = 5; //There seems to
be no good way to determine left padding
+ //No
getElement().getStyle().getPaddingLeft() doesn't work.
private final CascadeActionPanelCss style;
@@ -222,7 +228,7 @@
private void initializeCascadeMenuPanel() {
if (widgetMinWidth > 0) {
cascadePopupPanel.hide();
- int currentWidth = actionPanel.getParent().getOffsetWidth() -
siblingWidth;
+ int currentWidth = actionPanel.getParent().getOffsetWidth() -
siblingWidth - ACTION_PANEL_PADDING_LEFT;
actionPanel.getElement().getStyle().setProperty(MAX_WIDTH,
currentWidth - 1, Unit.PX);
if (currentWidth <= widgetMinWidth) {
cascadeButton.setVisible(true);
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml
index 34b72eb..83cf175 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml
@@ -90,11 +90,15 @@
.subTitledButton {
padding-left: 30px !important;
}
+
+ .actionPadding {
+ padding-left: 5px;
+ }
</ui:style>
<g:FlowPanel addStyleNames="{style.panel}">
<g:HTMLPanel ui:field="barPanel" addStyleNames="{style.bar}">
- <g:FlowPanel ui:field="actionPanel" />
+ <g:FlowPanel ui:field="actionPanel"
addStyleNames="{style.actionPadding}"/>
<g:PushButton ui:field="nextPageButton"
addStyleNames="{style.nextButtonStyle}">
<g:upFace image='{resources.pageNextEnable}' />
<g:upDisabledFace
image='{resources.pageNextDisable}' />
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabbedSplitLayout.css
b/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabbedSplitLayout.css
index e0700d9..8bff0e3 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabbedSplitLayout.css
+++
b/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabbedSplitLayout.css
@@ -3,7 +3,7 @@
background: transparent;
width: 8px;
height: 16px;
- z-index: 2;
+ z-index: 1;
padding: 0px 0px 0px 0px;
margin: 7px 0px 0px 0px;
position: absolute;
--
To view, visit http://gerrit.ovirt.org/24085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I151fc3a76d9c6f55e265688fbecf965326774497
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
