[Engine-patches] Change in ovirt-engine[master]: core: Fix templates search query

2014-02-02 Thread lzelkha
Liran Zelkha has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23811 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: core: Improve audit_log seach query

2014-02-02 Thread lzelkha
Liran Zelkha has posted comments on this change. Change subject: core: Improve audit_log seach query .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/23567 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: Add config value for Gluster task support

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add config value for Gluster task support .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_33_dao_unit_tests_gerrit

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: check if setup is reinstallable

2014-02-02 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: check if setup is reinstallable .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23972/1/packaging/setup/plugins/ovirt-engine-setup/

[Engine-patches] Change in ovirt-engine[master]: restapi: 'concurrent' Not Displayed For Primary PM Agent

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: 'concurrent' Not Displayed For Primary PM Agent .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests

[Engine-patches] Change in ovirt-engine[master]: restapi: 'concurrent' Not Displayed For Primary PM Agent

2014-02-02 Thread oliel
Ori Liel has posted comments on this change. Change subject: restapi: 'concurrent' Not Displayed For Primary PM Agent .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21781 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: restapi: 'concurrent' Not Displayed For Primary PM Agent

2014-02-02 Thread oliel
Ori Liel has submitted this change and it was merged. Change subject: restapi: 'concurrent' Not Displayed For Primary PM Agent .. restapi: 'concurrent' Not Displayed For Primary PM Agent When there's more than one Power-Managem

[Engine-patches] Change in ovirt-engine[master]: gluster: fix cleaning up orphan tasks

2014-02-02 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23936 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: Add config value for Gluster task support

2014-02-02 Thread sabose
Sahina Bose has uploaded a new change for review. Change subject: engine: Add config value for Gluster task support .. engine: Add config value for Gluster task support Added database config value for gluster task support. Chan

[Engine-patches] Change in ovirt-engine[master]: gluster: fix cleaning up orphan tasks

2014-02-02 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23936 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: gluster: fix cleaning up orphan tasks

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1331/ : SU

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Add tests to StorageHandlingCommandBaseTest

2014-02-02 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Add tests to StorageHandlingCommandBaseTest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23960 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: tools: Fix command line args in engine-manage-domains

2014-02-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Fix command line args in engine-manage-domains .. Patch Set 4: ChangePasswordUrl got changed to ChangePasswordMsg - which can be either custom message o

[Engine-patches] Change in ovirt-engine[master]: core: Fix templates search query

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1330/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: gluster: fix cleaning up orphan tasks

2014-02-02 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 1: (1 comment) New patch-set to follow after fixing unit test. http://gerrit.ovirt.org/#/c/23936/1/backend/man

[Engine-patches] Change in ovirt-engine[master]: core: Adds cli parser supporting short and long args

2014-02-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adds cli parser supporting short and long args .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23841 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Move ResourceManager to batch update VdsDynamic

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Move ResourceManager to batch update VdsDynamic .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ge

[Engine-patches] Change in ovirt-engine[master]: tools: Removes inclusion of config file in engine-manage-dom...

2014-02-02 Thread mperina
Martin Peřina has posted comments on this change. Change subject: tools: Removes inclusion of config file in engine-manage-domains.sh .. Patch Set 1: Yair, the fix Alon wanted to make, is included in 23840 -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: core: Improve audit_log seach query

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Improve audit_log seach query .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1328/

[Engine-patches] Change in ovirt-engine[master]: core: Eliminate unneeded updates to VdsDynamic

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Eliminate unneeded updates to VdsDynamic .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/13

[Engine-patches] Change in ovirt-engine[master]: core: Eliminate unneeded updates to VdsDynamic

2014-02-02 Thread lzelkha
Liran Zelkha has posted comments on this change. Change subject: core: Eliminate unneeded updates to VdsDynamic .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/23852 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: tools: Moves temp file creation from .sh to Java in engine-m...

2014-02-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Moves temp file creation from .sh to Java in engine-manage-domains .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23840 To uns

[Engine-patches] Change in ovirt-engine[master]: tools: Removes inclusion of config file in engine-manage-dom...

2014-02-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Removes inclusion of config file in engine-manage-domains.sh .. Patch Set 1: Code-Review+1 Alon, not sure I understood what you wanted there to be fixed

[Engine-patches] Change in ovirt-engine[master]: tools: Removes -interactive option from engine-manage-domains

2014-02-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Removes -interactive option from engine-manage-domains .. Patch Set 1: Please fix conflicts that occurred during attempt to rebase. -- To view, visit h

[Engine-patches] Change in ovirt-engine[master]: tools: Removes -interactive option from engine-manage-domains

2014-02-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Removes -interactive option from engine-manage-domains .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23838 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: tools: Remove auxiliary email address from EventSender inter...

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Remove auxiliary email address from EventSender interface .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_

[Engine-patches] Change in ovirt-engine[master]: engine: Validate that IDE disk is not read-only

2014-02-02 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: engine: Validate that IDE disk is not read-only .. Patch Set 2: Code-Review-1 Missing tests for new CDA flows in AddDisk and UpdateVmDisk commands in case the

[Engine-patches] Change in ovirt-engine[master]: 1. core, tools: Supporting change password Url presentation

2014-02-02 Thread mperina
Martin Peřina has posted comments on this change. Change subject: 1. core, tools: Supporting change password Url presentation .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/23250/11/backend/manager/tools/src/main/jav

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: tools: Provide better explaination on why setting password f...

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Provide better explaination on why setting password failed. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_un

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: tools: Provide better explaination on why setting password f...

2014-02-02 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tools: Provide better explaination on why setting password failed. .. Patch Set 1: * Tracker #1058957: OK * Set POST #1058957: OK, already on POST -- T

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: tools: Provide better explaination on why setting password f...

2014-02-02 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: tools: Provide better explaination on why setting password failed. .. tools: Provide better explaination on why setting password failed. Instead of providing

[Engine-patches] Change in ovirt-engine[master]: core: Eliminate unneeded updates to VdsDynamic

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Eliminate unneeded updates to VdsDynamic .. Patch Set 3: No Builds Executed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/

[Engine-patches] Change in ovirt-engine[master]: tools: Provide better explaination on why setting password f...

2014-02-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Provide better explaination on why setting password failed. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23933 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: Eliminate unneeded updates to VdsDynamic

2014-02-02 Thread liran . zelkha
Liran Zelkha has posted comments on this change. Change subject: core: Eliminate unneeded updates to VdsDynamic .. Patch Set 2: The performance is not consistent. I'm attempting to improve -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: Eliminate unneeded updates to VdsDynamic

2014-02-02 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Eliminate unneeded updates to VdsDynamic .. Patch Set 2: Eli, yes, this was question/idea. If this doesn't give the expected results, I'm fine with the s

[Engine-patches] Change in ovirt-engine[master]: core: Eliminate unneeded updates to VdsDynamic

2014-02-02 Thread liran . zelkha
Liran Zelkha has posted comments on this change. Change subject: core: Eliminate unneeded updates to VdsDynamic .. Patch Set 2: Yair - I've checked. Doing it at a DB level doesn't give the required results... -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: Improve audit_log seach query

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Improve audit_log seach query .. Patch Set 2: No Builds Executed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1323/ : NO

[Engine-patches] Change in ovirt-engine[master]: core: Move ResourceManager to batch update VdsDynamic

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Move ResourceManager to batch update VdsDynamic .. Patch Set 1: No Builds Executed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_

[Engine-patches] Change in ovirt-engine[master]: core: Fix templates search query

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 1: No Builds Executed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1321/ : NOT_B

[Engine-patches] Change in ovirt-engine[master]: core: Eliminate unneeded updates to VdsDynamic

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Eliminate unneeded updates to VdsDynamic .. Patch Set 2: No Builds Executed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 12: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-02 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 12: Verified-1 @Alon tests are failing, but please re-review the python :) -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-02 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 11: (8 comments) http://gerrit.ovirt.org/#/c/21052/11/build/helptag.py File build/helptag.p

[Engine-patches] Change in ovirt-engine[master]: core: Fix coverity report

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix coverity report .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1319/ : SUCCESS http:

[Engine-patches] Change in ovirt-engine[master]: core: Fix coverity report

2014-02-02 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fix coverity report .. core: Fix coverity report Fixed potential NPEs due to the fact that CommandBase.getBackendCommandObjectsHandler() may return null

[Engine-patches] Change in ovirt-log-collector[master]: sos: add sos 3.0 support

2014-02-02 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: sos: add sos 3.0 support .. Patch Set 2: Code-Review+1 (2 comments) >From my review looks good let's see the others guys. http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support classless IN-ADDR.ARPA delegation

2014-02-02 Thread love . cairn
Mark Kachi has posted comments on this change. Change subject: packaging: setup: support classless IN-ADDR.ARPA delegation .. Patch Set 2: Hi Alon, Thank you for your advice. To describe how RFC2317 is used, please check foll

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support classless IN-ADDR.ARPA delegation

2014-02-02 Thread love . cairn
Mark Kachi has posted comments on this change. Change subject: packaging: setup: support classless IN-ADDR.ARPA delegation .. Patch Set 1: Thank you for checking my patch. Please see following log output. =

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix typo in VdsDeploy

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix typo in VdsDeploy .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_find_bugs_gerrit/5262/ : SUCCESS http://j

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: block virtio-scsi for unsupported OSes

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: block virtio-scsi for unsupported OSes .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/457/ :

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: managed removal of memory volumes in negative flows

2014-02-02 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: managed removal of memory volumes in negative flows .. core: managed removal of memory volumes in negative flows On failure while importing VM or cr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix typo in VdsDeploy

2014-02-02 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix typo in VdsDeploy .. Patch Set 2: * Tracker #1056307: OK * Set POST #1056307: OK, already on POST -- To view, visit http://gerrit.ovirt.org/23

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix typo in VdsDeploy

2014-02-02 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: fix typo in VdsDeploy .. core: fix typo in VdsDeploy Change-Id: I6d5b0784be20e37f95348af33a217dead0fd5ffb Bug-Url: https://bugzilla.redhat.com/10563

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: block virtio-scsi for unsupported OSes

2014-02-02 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: block virtio-scsi for unsupported OSes .. Patch Set 5: * Tracker #1038613: OK * Set POST #1038613: OK, already on POST -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: block virtio-scsi for unsupported OSes

2014-02-02 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: block virtio-scsi for unsupported OSes .. core: block virtio-scsi for unsupported OSes Block VirtIO-SCSI for unsupported operation systems: * Added

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: validate disks existence on create snapshot

2014-02-02 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: validate disks existence on create snapshot .. core: validate disks existence on create snapshot CreateAllSnapshotsFromVmCommand: Added validation f

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Don't attach external networks to NIC by label

2014-02-02 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Don't attach external networks to NIC by label .. webadmin: Don't attach external networks to NIC by label External networks shouldn't be static

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Propagate the exception from VDSM to the user

2014-02-02 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: Propagate the exception from VDSM to the user .. core: Propagate the exception from VDSM to the user Propagate the exception got from VDSM instead r

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Remove redundant else

2014-02-02 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: Remove redundant else .. core: Remove redundant else There is no use for the else phase since when the if condition is true we already throw an exce

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Execute clear tasks with new thread.

2014-02-02 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: Execute clear tasks with new thread. .. core: Execute clear tasks with new thread. clearAsyncTasksWithOutVdsmId is executed at the finally step when

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Use shorter scope for try catch block

2014-02-02 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: Use shorter scope for try catch block .. core: Use shorter scope for try catch block There is no need to put try catch block on createTask since it

[Engine-patches] Change in ovirt-engine[master]: utils: add getProperty with an optionalSuffix String.

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add getProperty with an optionalSuffix String. .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_t

[Engine-patches] Change in ovirt-engine[master]: utils: add getProperty with an optionalSuffix String.

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add getProperty with an optionalSuffix String. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_t

[Engine-patches] Change in ovirt-engine[master]: utils: add getProperty with an optionalSuffix String.

2014-02-02 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: utils: add getProperty with an optionalSuffix String. .. utils: add getProperty with an optionalSuffix String. public String getProperty(String key, String option

[Engine-patches] Change in ovirt-engine[master]: core: refactor OvfVmReader#readHardwareSection

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: refactor OvfVmReader#readHardwareSection .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/13

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: move build config to proper place as well

2014-02-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well .. Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/23617/11/packaging/setup/plugins/ovirt-engi

[Engine-patches] Change in ovirt-engine[master]: core: refactor OvfVmReader#readHardwareSection

2014-02-02 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: core: refactor OvfVmReader#readHardwareSection .. core: refactor OvfVmReader#readHardwareSection Change-Id: I403489679eb97359842a3662278b7312a81911fd Signed-off-by

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: move build config to proper place as well

2014-02-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/23617/11/packaging/setup/plugins/ovirt-engin

[Engine-patches] Change in ovirt-engine[master]: engine: Use getFileStats to retrieve iso and floppy files

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Use getFileStats to retrieve iso and floppy files .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_test

[Engine-patches] Change in ovirt-engine[master]: engine: Validate that IDE disk is not read-only

2014-02-02 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Validate that IDE disk is not read-only .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23953 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: engine: Use getFileStats to retrieve iso and floppy files

2014-02-02 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Use getFileStats to retrieve iso and floppy files .. Patch Set 7: Verified+1 Rebased and verified. -- To view, visit http://gerrit.ovirt.org/21524 To u

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: move build config to proper place as well

2014-02-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well .. Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/23617/11/packaging/setup/plugins/ovirt-engi

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Block live storage migration to domain of a different ...

2014-02-02 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Block live storage migration to domain of a different type .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23962 To unsubscribe,

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Block live storage migration to domain of a different ...

2014-02-02 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Block live storage migration to domain of a different type .. Patch Set 1: @Tal - please verify -- To view, visit http://gerrit.ovirt.org/23962 To unsub

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: move build config to proper place as well

2014-02-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well .. Patch Set 9: (7 comments) http://gerrit.ovirt.org/#/c/23617/9/packaging/setup/plugins/ovirt-engine

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: move build config to proper place as well

2014-02-02 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well .. Patch Set 7: (5 comments) http://gerrit.ovirt.org/#/c/23617/7/packaging/setup/plugins/ovirt-engine-s

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: Only top level elements in root class map

2014-02-02 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: codegen: Only top level elements in root class map .. Patch Set 1: This is my understanding of why we need this dictionary: 1. The XML to Python converter need

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: move build config to proper place as well

2014-02-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/23617/8/packaging/setup/plugins/ovirt-engine-

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: On upgrade use existing NFS export ACL

2014-02-02 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: On upgrade use existing NFS export ACL .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23736/1/packaging/setup/plugins/ovirt-engi

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Overwrite iso nfs export only if new

2014-02-02 Thread didi
Yedidyah Bar David has uploaded a new change for review. Change subject: packaging: setup: Overwrite iso nfs export only if new .. packaging: setup: Overwrite iso nfs export only if new Only overwrite the nfs export line for the

[Engine-patches] Change in ovirt-engine[master]: frontend: console models cache

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: frontend: console models cache .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1314/ : SUCCESS

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: move build config to proper place as well

2014-02-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well .. Patch Set 7: (6 comments) http://gerrit.ovirt.org/#/c/23617/7/packaging/setup/plugins/ovirt-engine

[Engine-patches] Change in ovirt-engine[master]: frontend: Prepare frontend for console unit tests

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: frontend: Prepare frontend for console unit tests .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit

[Engine-patches] Change in ovirt-engine[master]: frontend: Prepare frontend for console unit tests

2014-02-02 Thread fkobzik
Frank Kobzik has uploaded a new change for review. Change subject: frontend: Prepare frontend for console unit tests .. frontend: Prepare frontend for console unit tests This patch makes couple of adjustments for console models

[Engine-patches] Change in ovirt-engine[master]: frontend: console models cache

2014-02-02 Thread fkobzik
Frank Kobzik has uploaded a new change for review. Change subject: frontend: console models cache .. frontend: console models cache This patch adds first part of console tests, which test *ConsoleModel classes. Change-Id: I767e

[Engine-patches] Change in ovirt-engine[master]: engine: VmInit root-password not set on Pool creation

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: VmInit root-password not set on Pool creation .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ge

[Engine-patches] Change in ovirt-engine[master]: engine: VmInit root-password not set on Pool creation

2014-02-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: VmInit root-password not set on Pool creation .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ge

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: check if setup is reinstallable

2014-02-02 Thread didi
Yedidyah Bar David has uploaded a new change for review. Change subject: packaging: setup: check if setup is reinstallable .. packaging: setup: check if setup is reinstallable Change-Id: I76b8e7910e4f8b88592a75e92354443e1bf964dd

[Engine-patches] Change in ovirt-engine[master]: engine: VmInit root-password not set on Pool creation

2014-02-02 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: engine: VmInit root-password not set on Pool creation .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23971 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: engine: VmInit root-password not set on Pool creation

2014-02-02 Thread shavivi
Shahar Havivi has uploaded a new change for review. Change subject: engine: VmInit root-password not set on Pool creation .. engine: VmInit root-password not set on Pool creation Change-Id: I9206906e3b61551023b21e4358663a4842018

[Engine-patches] Change in ovirt-engine[master]: engine: Exclude read-only disks when creating a snapshot

2014-02-02 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Exclude read-only disks when creating a snapshot .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23954 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: Incorrect mapping: DWH_STOPPED - History Service Started

2014-02-02 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: Incorrect mapping: DWH_STOPPED - History Service Started .. Patch Set 1: > @Einav, I see that the translation is wrong as well. translations will be OK - once I w

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: Only top level elements in root class map

2014-02-02 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: codegen: Only top level elements in root class map .. Patch Set 1: btw, there is another way to achieve the same, - via local buildChildren() methods, see if

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: Only top level elements in root class map

2014-02-02 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: codegen: Only top level elements in root class map .. Patch Set 1: Code-Review-2 Juan, I think you've misunderstood the concept, the reason for this map is

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: rewrite

2014-02-02 Thread ydary
Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: rewrite .. packaging: setup: rewrite upgrade from legacy is not supported. Change-Id: I7ba43528b49d39019288819b5a54bf5a0514a677 Signed-o

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: rewrite

2014-02-02 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 6: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23785 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: distro-rpm: fix typo in new package detection

2014-02-02 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: distro-rpm: fix typo in new package detection .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23967 To unsubscrib

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: rewrite

2014-02-02 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/23785/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/d

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: distro-rpm: fix typo in new package detection

2014-02-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: distro-rpm: fix typo in new package detection .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/23967 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: distro-rpm: fix typo in new package detection

2014-02-02 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: distro-rpm: fix typo in new package detection .. packaging: setup: distro-rpm: fix typo in new package detection Change-Id: Ibb2aa3ce1f1d9f0d4c

  1   2   >