Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/23617/8/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 882: def _cleanup(self): Line 883: if self._temproot is not None and os.path.exists(self._temproot): Line 884: shutil.rmtree(self._temproot) Line 885: Line 886: if os.path.exists( please move to CLOSEUP stage and use loop to cleanup at one logic. Line 887: os.path.join( Line 888: self.environment[ Line 889: oreportscons.ConfigEnv.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR Line 890: ], -- To view, visit http://gerrit.ovirt.org/23617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a384db8bc93dd0a5c0a0fe43e2c59e8e474a97 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
