Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/23617/11/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 509: if os.path.exists( Line 510: oreportscons.FileLocations.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 511: ) and not os.path.exists( Line 512: oreportscons.FileLocations.OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 513: ): :) should be: if ( not os.path.exists( ) and os.path.exists ( ) ): Line 514: self.logger.info(_('Copying old war to new location')) Line 515: shutil.copytree( Line 516: oreportscons.FileLocations.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 517: oreportscons.FileLocations.OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 880: 'build-conf', Line 881: ), Line 882: ): Line 883: if os.path.exists(d): Line 884: self.logger.info(_('Removing folder: %s', d)) this should not be info, is not interesting to user. self.logger.debug('xxxx %s', d) for interesting messages should have been: self.logger.info( _('xxx {directory}').format( directory=d, ) ) for sane gettext translation. Line 885: shutil.rmtree(d) Line 886: Line 887: @plugin.event( Line 888: stage=plugin.Stages.STAGE_CLEANUP, -- To view, visit http://gerrit.ovirt.org/23617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a384db8bc93dd0a5c0a0fe43e2c59e8e474a97 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
