Douglas Schilling Landgraf has posted comments on this change. Change subject: sos: add sos 3.0 support ......................................................................
Patch Set 2: Code-Review+1 (2 comments) >From my review looks good let's see the others guys. http://gerrit.ovirt.org/#/c/23793/2/src/sos3/plugins/ovirt-engine.py File src/sos3/plugins/ovirt-engine.py: Maybe add a header with license/copyright? Line 1: import os Line 2: import re Line 3: import signal Line 4: import subprocess http://gerrit.ovirt.org/#/c/23793/2/src/sos3/plugins/ovirt-postgresql.py File src/sos3/plugins/ovirt-postgresql.py: Maybe add a header with license/copyright? Line 1: import os Line 2: import tempfile Line 3: Line 4: from sos.plugins import Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin -- To view, visit http://gerrit.ovirt.org/23793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47fb7817727ed88a1b9c7bb91cb5055a2e8d7565 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
