Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well ......................................................................
Patch Set 7: (6 comments) http://gerrit.ovirt.org/#/c/23617/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 511: self.environment[ Line 512: oreportscons.ConfigEnv.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR Line 513: ], Line 514: ) Line 515: ): indent should be 4... this will not pass pyflakes/pep8 Line 516: self.logger.info(_('Copying old war to new location')) Line 517: shutil.copytree( Line 518: LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 519: OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 516: self.logger.info(_('Copying old war to new location')) Line 517: shutil.copytree( Line 518: LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 519: OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 520: symlinks=True comma at end Line 521: ) Line 522: Line 523: if os.path.exists( Line 524: os.path.join( Line 527: ], Line 528: 'buildomatic', Line 529: 'build-conf', Line 530: ) Line 531: ): same... you have issue with indent... the closing ): should be at same column of if. Line 532: Line 533: self.logger.info(_('Regenerating build conf files')) Line 534: Line 535: rc, stdout, stderr = self.execute( Line 883: def _cleanup(self): Line 884: if self._temproot is not None and os.path.exists(self._temproot): Line 885: shutil.rmtree(self._temproot) Line 886: Line 887: if os.path.exists( no... this should be on STAGE_CLOSEUP, so execute only if success... but I will fix that. Line 888: os.path.join( Line 889: self.environment[ Line 890: oreportscons.ConfigEnv.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR Line 891: ], Line 889: self.environment[ Line 890: oreportscons.ConfigEnv.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR Line 891: ], Line 892: ) Line 893: ): same... indent... Line 894: self.logger.info(_('Removing old war')) Line 895: shutil.rmtree(LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR) Line 896: Line 897: if os.path.exists( Line 892: ) Line 893: ): Line 894: self.logger.info(_('Removing old war')) Line 895: shutil.rmtree(LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR) Line 896: you should loop... for d in (1, 2, 3): if exist(d): remove(d) Line 897: if os.path.exists( Line 898: os.path.join( Line 899: self.environment[ Line 900: oreportscons.ConfigEnv.JASPER_HOME -- To view, visit http://gerrit.ovirt.org/23617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a384db8bc93dd0a5c0a0fe43e2c59e8e474a97 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
