Michael Pasternak has posted comments on this change. Change subject: codegen: Only top level elements in root class map ......................................................................
Patch Set 1: Code-Review-2 Juan, I think you've misunderstood the concept, the reason for this map is being able to create correlation between element name and actual type representing this element at runtime, in python (client->server), i.e lets say we have <foo> <name=nics type=nics1> </foo> <bar> <name=nics type=nics2> </bar> if in python we create object foo() and object bar() both foo.nics and bar.nics will be None, and in order to create them later, you'll have to know the actual type of .nics, and since it's ambiguous - you can't aim for deterministic behaviour of sdk. so as you can see, it has nothing to do with .nics not being a top level object in the xml, other way round is creating context aware caching where in context of bar nics will mean nics2 and in context of foo it will be a nics1, but it way too complex at least for maintenance, in any case, this patch does not address the problem you have mentioned. -- To view, visit http://gerrit.ovirt.org/23964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcdefe71f3d15ab0da841f35b4b94916d19d950d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
