Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move build config to proper place as well ......................................................................
Patch Set 9: (7 comments) http://gerrit.ovirt.org/#/c/23617/9/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 506: ) Line 507: def _export(self): Line 508: Line 509: if os.path.exists( Line 510: os.path.join( no need to join if nothing to join... Line 511: self.environment[ Line 512: oreportscons.ConfigEnv.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR Line 513: ], Line 514: ) Line 509: if os.path.exists( Line 510: os.path.join( Line 511: self.environment[ Line 512: oreportscons.ConfigEnv.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR Line 513: ], I do not think it is in environment... Line 514: ) Line 515: ): Line 516: self.logger.info(_('Copying old war to new location')) Line 517: shutil.copytree( Line 514: ) Line 515: ): Line 516: self.logger.info(_('Copying old war to new location')) Line 517: shutil.copytree( Line 518: LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR, reportscons.FileLocations. ... Line 519: OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 520: symlinks=True, Line 521: ) Line 522: Line 515: ): Line 516: self.logger.info(_('Copying old war to new location')) Line 517: shutil.copytree( Line 518: LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 519: OVIRT_ENGINE_REPORTS_JASPER_WAR, same... Line 520: symlinks=True, Line 521: ) Line 522: Line 523: if os.path.exists( Line 878: Line 879: @plugin.event( Line 880: stage=plugin.Stages.STAGE_CLOSEUP, Line 881: ) Line 882: no space Line 883: def _closeup(self): Line 884: for d in ( Line 885: os.path.join( Line 886: self.environment[ Line 881: ) Line 882: Line 883: def _closeup(self): Line 884: for d in ( Line 885: os.path.join( no need to join if nothing to join :))) Line 886: self.environment[ Line 887: oreportscons.ConfigEnv.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR Line 888: ], Line 889: ), Line 884: for d in ( Line 885: os.path.join( Line 886: self.environment[ Line 887: oreportscons.ConfigEnv.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR Line 888: ], not in environment... Line 889: ), Line 890: os.path.join( Line 891: self.environment[ Line 892: oreportscons.ConfigEnv.JASPER_HOME -- To view, visit http://gerrit.ovirt.org/23617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a384db8bc93dd0a5c0a0fe43e2c59e8e474a97 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
