[Engine-patches] Change in ovirt-engine[master]: restapi : Reverting Missing opertions for snapshots in RESTA...

2013-11-16 Thread abaron
Ayal Baron has posted comments on this change. Change subject: restapi : Reverting Missing opertions for snapshots in RESTAPI(#867339) .. Patch Set 1: (1 comment) Commit Me

[Engine-patches] Change in ovirt-engine[master]: engine: Remove concreteStorageType property from StorageType...

2013-11-16 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Remove concreteStorageType property from StorageType enum. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21312 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Remove AddStorageDomainCommand.checkExistingStorageD...

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Remove AddStorageDomainCommand.checkExistingStorageDomain .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_upd

[Engine-patches] Change in ovirt-engine[master]: engine: Remove unused method from AddExistingFileStorageDoma...

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Remove unused method from AddExistingFileStorageDomainCommand .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3

[Engine-patches] Change in ovirt-engine[master]: engine: Remove unused method from AddExistingFileStorageDoma...

2013-11-16 Thread sgotliv
Sergey Gotliv has uploaded a new change for review. Change subject: engine: Remove unused method from AddExistingFileStorageDomainCommand .. engine: Remove unused method from AddExistingFileStorageDomainCommand Change-Id: I2196

[Engine-patches] Change in ovirt-engine[master]: engine: Remove AddStorageDomainCommand.checkExistingStorageD...

2013-11-16 Thread sgotliv
Sergey Gotliv has uploaded a new change for review. Change subject: engine: Remove AddStorageDomainCommand.checkExistingStorageDomain .. engine: Remove AddStorageDomainCommand.checkExistingStorageDomain There is no reason to ke

[Engine-patches] Change in ovirt-engine[master]: webadmin: VM GuideMe - update dialog on attach disk

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: VM GuideMe - update dialog on attach disk .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste

[Engine-patches] Change in ovirt-engine[master]: webadmin: VM GuideMe - update dialog on attach disk

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: VM GuideMe - update dialog on attach disk .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste

[Engine-patches] Change in ovirt-engine[master]: webadmin: VM GuideMe - update dialog on attach disk

2013-11-16 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: VM GuideMe - update dialog on attach disk .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21090 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: webadmin: VM GuideMe - update dialog on attach disk

2013-11-16 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VM GuideMe - update dialog on attach disk .. webadmin: VM GuideMe - update dialog on attach disk VM Guide Me: Update 'Configure Virtual Disks' b

[Engine-patches] Change in ovirt-engine[master]: core: Allow activate an already active domain

2013-11-16 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: Allow activate an already active domain .. Patch Set 2: IMO the correct behavior is a returned CDA message that the domain is already active -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: engine: Remove concreteStorageType property from StorageType...

2013-11-16 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: engine: Remove concreteStorageType property from StorageType enum. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21312 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Allow activate an already active domain

2013-11-16 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: core: Allow activate an already active domain .. Patch Set 2: Code-Review-1 (1 comment) Commit Message

[Engine-patches] Change in ovirt-engine[master]: core: Host shouldn't move to UP if it's already connected to...

2013-11-16 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Host shouldn't move to UP if it's already connected to other pool .. Patch Set 2: Code-Review-1 (1 comment) ..

[Engine-patches] Change in ovirt-engine[master]: engine: Simplify AddStorageDomainCommand.conectStorage

2013-11-16 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: engine: Simplify AddStorageDomainCommand.conectStorage .. Patch Set 1: Code-Review+1 (1 comment) File bac

[Engine-patches] Change in ovirt-engine[master]: engine: Simplify AddStorageDomainCommand.conectStorage

2013-11-16 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: engine: Simplify AddStorageDomainCommand.conectStorage .. Patch Set 1: -Code-Review Other than my comment looks good. -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: Clean pending memory and CPUs only during init

2013-11-16 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Clean pending memory and CPUs only during init .. Patch Set 3: (1 comment) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: core: Clean pending memory and CPUs only during init

2013-11-16 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Clean pending memory and CPUs only during init .. Patch Set 2: (1 comment) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: engine: Unsupported vnic profile features report for 3.0 clu...

2013-11-16 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Unsupported vnic profile features report for 3.0 clusters .. Patch Set 1: (1 comment) Small comment ..

[Engine-patches] Change in ovirt-engine[master]: core: Allow activate an already active domain

2013-11-16 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: Allow activate an already active domain .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21320 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: engine: Simplify AddStorageDomainCommand.conectStorage

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Simplify AddStorageDomainCommand.conectStorage .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_ma

[Engine-patches] Change in ovirt-engine[master]: engine: Simplify AddStorageDomainCommand.conectStorage

2013-11-16 Thread sgotliv
Sergey Gotliv has uploaded a new change for review. Change subject: engine: Simplify AddStorageDomainCommand.conectStorage .. engine: Simplify AddStorageDomainCommand.conectStorage 1. Convert single connection in to the list onl

[Engine-patches] Change in ovirt-engine[master]: core: Allow activate an already active domain

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Allow activate an already active domain .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerr

[Engine-patches] Change in ovirt-engine[master]: core: Allow activate an already active domain

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Allow activate an already active domain .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerr

[Engine-patches] Change in ovirt-engine[master]: core: Allow activate an already active domain

2013-11-16 Thread vvolansk
Vered Volansky has uploaded a new change for review. Change subject: core: Allow activate an already active domain .. core: Allow activate an already active domain Using rest to try to activate an already active domain was an il

[Engine-patches] Change in ovirt-engine[master]: engine: Remove redundant constant IrsBrokerCommand.BYTES_TO_GB

2013-11-16 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Remove redundant constant IrsBrokerCommand.BYTES_TO_GB .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21314 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: restapi : Reverting Missing opertions for snapshots in RESTA...

2013-11-16 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: restapi : Reverting Missing opertions for snapshots in RESTAPI(#867339) .. Patch Set 1: Code-Review-1 (1 comment) .

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 1269 - Failure!

2013-11-16 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1269/ Build Number: 1269 Build Status: Failure Triggered By: Started by timer - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: engine : Change parameter type of CommandBase

2013-11-16 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Change parameter type of CommandBase .. Patch Set 2: We need another patch for api code to work with VdcParametersMap. Will work on that -- To view, visi

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms ยป centos64 - Build # 1269 - Failure!

2013-11-16 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/./label=centos64/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/./label=centos64/1269/ Build Number: 1269 Build Status: Failure Triggered By: Started by upstream project "ovirt-engine_create_rpms" build number 1,269

[Engine-patches] Change in ovirt-engine[master]: engine: Remove StorageType.ALL value

2013-11-16 Thread laravot
Liron Ar has posted comments on this change. Change subject: engine: Remove StorageType.ALL value .. Patch Set 1: (1 comment) what about upgrade? older version users might have the value persisted in the db? if it's possible,

[Engine-patches] Change in ovirt-engine[master]: core: Default DC & Cluster has fixed UUIDs

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Default DC & Cluster has fixed UUIDs .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/

[Engine-patches] Change in ovirt-engine[master]: core: Default DC & Cluster has fixed UUIDs

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Default DC & Cluster has fixed UUIDs .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/

[Engine-patches] Change in ovirt-engine[master]: core: Default DC & Cluster has fixed UUIDs

2013-11-16 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core: Default DC & Cluster has fixed UUIDs .. core: Default DC & Cluster has fixed UUIDs When installing several RHEV environments and having integrated ma

[Engine-patches] Change in ovirt-engine[master]: core: Default DC & Cluster has fixed UUIDs

2013-11-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Default DC & Cluster has fixed UUIDs .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21040 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: engine : Change parameter type of CommandBase

2013-11-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine : Change parameter type of CommandBase .. Patch Set 2: (3 comments) BEAUTIFUL Now if we rebase the patches that removes the usage of the parameters c

[Engine-patches] Change in ovirt-engine[master]: frontend: Refactored UnitVmModel to support generics

2013-11-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: frontend: Refactored UnitVmModel to support generics .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21298 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: engine : Change parameter type of CommandBase

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Change parameter type of CommandBase .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerr

[Engine-patches] Change in ovirt-engine[master]: core: Host shouldn't move to UP if it's already connected to...

2013-11-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Host shouldn't move to UP if it's already connected to other pool .. Patch Set 2: (1 comment) File back

[Engine-patches] Change in ovirt-engine[master]: engine : Change parameter type of CommandBase

2013-11-16 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Change parameter type of CommandBase .. Patch Set 2: Handled #2 -- To view, visit http://gerrit.ovirt.org/21319 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: engine: Remove StorageType.ALL value

2013-11-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: engine: Remove StorageType.ALL value .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21315 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: engine: unresolved placeholder in getDeviceVisibility error ...

2013-11-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: unresolved placeholder in getDeviceVisibility error message .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_u

[Engine-patches] Change in ovirt-engine[master]: engine: unresolved placeholder in getDeviceVisibility error ...

2013-11-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: engine: unresolved placeholder in getDeviceVisibility error message .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/21246 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: engine: unresolved placeholder in getDeviceVisibility error ...

2013-11-16 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: engine: unresolved placeholder in getDeviceVisibility error message .. engine: unresolved placeholder in getDeviceVisibility error message GetDeviceVisibil

[Engine-patches] Change in ovirt-engine[master]: engine: unresolved placeholder in getDeviceVisibility error ...

2013-11-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: engine: unresolved placeholder in getDeviceVisibility error message .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21246 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine, restapi: Remove redundant SizeConverter

2013-11-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: engine, restapi: Remove redundant SizeConverter .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21313 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: engine: Remove redundant constant IrsBrokerCommand.BYTES_TO_GB

2013-11-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: engine: Remove redundant constant IrsBrokerCommand.BYTES_TO_GB .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21314 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: engine: Remove concreteStorageType property from StorageType...

2013-11-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: engine: Remove concreteStorageType property from StorageType enum. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21312 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: SearchQuery generates slow query on vds_with_tags an...

2013-11-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine: SearchQuery generates slow query on vds_with_tags and storage_domains .. Patch Set 6: (1 comment) Fil

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: adding utility for db objects owner change

2013-11-16 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: adding utility for db objects owner change .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21277 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: engine : Change parameter type of CommandBase

2013-11-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine : Change parameter type of CommandBase .. Patch Set 1: > Can you elaborate what you mean in #1. Hmm... I jut thought that instead of List we can use a typ

[Engine-patches] Change in ovirt-engine[master]: engine : Change parameter type of CommandBase

2013-11-16 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Change parameter type of CommandBase .. Patch Set 1: Can you elaborate what you mean in #1. I will look into #2. -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: webadmin : reordered fields in rebalance status pop up

2013-11-16 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin : reordered fields in rebalance status pop up .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21158 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin : Fix for Remove-brick Commit confirmation

2013-11-16 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin : Fix for Remove-brick Commit confirmation .. Patch Set 1: (1 comment) File frontend/webadmin/modul

[Engine-patches] Change in ovirt-engine[master]: engine : Change parameter type of CommandBase

2013-11-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine : Change parameter type of CommandBase .. Patch Set 1: (2 comments) Great! I am not sure I understand maybe there is some limitation... and we discus

[Engine-patches] Change in ovirt-engine[master]: engine: Add infrastructure code for removal of parameter cla...

2013-11-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: Add infrastructure code for removal of parameter classes .. Patch Set 15: (1 comment) File backend/

[Engine-patches] Change in ovirt-engine[master]: engine: Add infrastructure code for removal of parameter cla...

2013-11-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: Add infrastructure code for removal of parameter classes .. Patch Set 14: (1 comment) File backend/