Omer Frenkel has posted comments on this change.
Change subject: core: Host shouldn't move to UP if it's already connected to
other pool
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 221:
getStorageDomainDAO().getStorageDomainByTypeAndPool(storagePoolId,
StorageDomainType.Master);
Line 222: boolean masterDomainInactiveOrUnknown =
masterDomain.getStatus() == StorageDomainStatus.InActive
Line 223: || masterDomain.getStatus() ==
StorageDomainStatus.Unknown;
Line 224:
Line 225: VDSReturnValue returnValue =
ResourceManager.getInstance().runVdsCommand(VDSCommandType.ConnectStoragePool,
No. bll-vdsbroker were meant to work in client-server way.
if we dont think its needed and want to remove it, thats fine.
but while its there, lets not hack around it whenever we want just because we
can.
there are other ways to solve the problem:
a. fix ConnectStoragePool command to work as you expect it.
b. check for the result in addition to catching the exception and then do your
bigger fix.
Line 226: new
ConnectStoragePoolVDSCommandParameters(vds.getId(), storagePoolId,
Line 227: vds.getVdsSpmId(), masterDomain.getId(),
Line 228: storagePool.getmaster_domain_version()));
Line 229: if (!returnValue.getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/21095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3d8268516b010f7831b59bbc6331cfd70efec1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
