Mike Kolesnik has posted comments on this change. Change subject: engine: Unsupported vnic profile features report for 3.0 clusters ......................................................................
Patch Set 1: (1 comment) Small comment .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java Line 261: event.addCustomValue("UnsupportedFeatures", StringUtils.join(unsupportedFeatureNames, ", ")); Line 262: AuditLogDirector.log(event, AuditLogType.VNIC_PROFILE_UNSUPPORTED_FEATURES); Line 263: } Line 264: Line 265: protected static enum VNIC_PROFILE_PROPERTIES { Inner types definitions should go at the end of the class in oVirt Line 266: PORT_MIRRORING("Port Mirroring"), Line 267: CUSTOM_PROPERTIES("Custom Properties"), Line 268: NETWORK_QOS("Network QoS"); Line 269: -- To view, visit http://gerrit.ovirt.org/21288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f01229169e74bdd96ad989e89f7f0beaebf5a4b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches