Roy Golan has posted comments on this change.

Change subject: core: Clean pending memory and CPUs only during init
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
Line 111:                 _saveVdsDynamic = true;
Line 112:             }
Line 113: 
Line 114:             if (_saveVdsDynamic) {
Line 115:                 
DbFacade.getInstance().getVdsDynamicDao().update(_vds.getDynamicData());
Doron this could well be an issue when we have thousands of VMs . it can cause 
slow startup time which we have an easy way around using Liran's nice batch 
work - really no-brainer and great benefit
Line 116:             }
Line 117:         }
Line 118: 
Line 119:         // Populate the VDS dictionary


-- 
To view, visit http://gerrit.ovirt.org/20172
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2ba29368c0b6bc400087512d7b3a68c5c8f5c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to