Kanagaraj M has posted comments on this change.

Change subject: webadmin : Fix for Remove-brick Commit confirmation
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
Line 1304:             showRemoveBricksStatus();
Line 1305:         } else if 
(command.getName().equals("StopRemoveBricksOnStatus")) { //$NON-NLS-1$
Line 1306:             getStopRemoveBricksCommand().execute();
Line 1307:         } else if 
(command.getName().equals("CommitRemoveBricksOnStatus")) { //$NON-NLS-1$
Line 1308:             commitRemoveBricks();
I don't see any different behavior in this change?

Can you explain the problem&solution in the commit msg?
Line 1309:         } else if 
(command.getName().equals("CancelRemoveBricksStatus")) { //$NON-NLS-1$
Line 1310:             cancelRemoveBrickStatus();
Line 1311:         } else if (command.equals(getRetainBricksCommand())) {
Line 1312:             retainBricks();


-- 
To view, visit http://gerrit.ovirt.org/21270
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e2c9fd6e64826781e2e93ff337dfa76dd06f1e1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to