[Engine-patches] Change in ovirt-engine[master]: engine: Simplify AddStorageDomainCommand.conectStorage

[sgotliv]

Sergey Gotliv has uploaded a new change for review.

Change subject: engine: Simplify AddStorageDomainCommand.conectStorage
......................................................................

engine: Simplify AddStorageDomainCommand.conectStorage

1. Convert single connection in to the list only once.
2. Remove inline imports.

Change-Id: I80beec8f08b0e6fa397177bfb00b4b4cb2570348
Signed-off-by: Sergey Gotliv <sgot...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
1 file changed, 10 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/21321/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
index 20f206e..bacac33 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
@@ -4,7 +4,9 @@
 
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
 
 import org.ovirt.engine.core.bll.Backend;
@@ -126,18 +128,15 @@
     protected Pair<Boolean, Integer> connectStorage() {
         String connectionId = getStorageDomain().getStorage();
         StorageServerConnections connection = 
getStorageServerConnectionDAO().get(connectionId);
-        java.util.HashMap<String, String> result = (java.util.HashMap<String, 
String>) runVdsCommand(
-                        VDSCommandType.ConnectStorageServer,
-                        new 
StorageServerConnectionManagementVDSParameters(getParameters().getVdsId(), 
Guid.Empty,
-                                connection.getstorage_type(),
-                                new 
java.util.ArrayList<StorageServerConnections>(java.util.Arrays
-                                        .asList(new StorageServerConnections[] 
{ connection }))))
-                .getReturnValue();
-        return new Pair<Boolean, Integer>(StorageHelperDirector.getInstance()
-                .getItem(connection.getstorage_type())
-                .isConnectSucceeded(result, Arrays.asList(connection)),
-                 Integer.parseInt(result.values().iterator().next()));
+        List<StorageServerConnections> connections = Arrays.asList(connection);
 
+        Map<String, String> result = (HashMap<String, String>) runVdsCommand(
+                        VDSCommandType.ConnectStorageServer,
+                        new 
StorageServerConnectionManagementVDSParameters(getParameters().getVdsId(),
+                                Guid.Empty, connection.getstorage_type(), 
connections)).getReturnValue();
+
+        return new 
Pair<>(StorageHelperDirector.getInstance().getItem(connection.getstorage_type())
+                .isConnectSucceeded(result, connections), 
Integer.parseInt(result.values().iterator().next()));
     }
 
     @Override


-- 
To view, visit http://gerrit.ovirt.org/21321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80beec8f08b0e6fa397177bfb00b4b4cb2570348
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches