Roy Golan has posted comments on this change.
Change subject: core: Clean pending memory and CPUs only during init
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java
Line 264: .addValue("pendingVmemSize", pendingVmemSize)
Line 265: .addValue("memCommited", memCommited)
Line 266: .addValue("vmsCoresCount", vmsCoresCount);
Line 267:
Line 268: log.debugFormat("updatePartialVdsDynamicCalc Guid:{0}
vmCount:{1} pendingCPUs:{2} pendingMem:{3}"
* but this is unnecessary stuff in the code if you can already get that for free
* the debug log of the underlying layer is more accurate than whatever we will
put here
* its doesn't need maintenance if we ever update/add/remove more fields
* debug log, unfortunatly is being used *rarely* - if someone what's to see
engine.dal log he anyway opens it all, and its also very usefull to see other
read/writes from/to the db with it.
* last - there is no place in the DbFacade/DAOs where we put log and we should
keep it clean like that
Line 269: + " commitedMem:{4} commitedCpus:{5}",
Line 270: id, vmCount, pendingVcpusCount,
pendingVmemSize, memCommited, vmsCoresCount);
Line 271:
Line 272:
getCallsHandler().executeModification("UpdatePartialVdsDynamicCalc",
parameterSource);
--
To view, visit http://gerrit.ovirt.org/20172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2ba29368c0b6bc400087512d7b3a68c5c8f5c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
