Yaniv Dary has submitted this change and it was merged.
Change subject: etl: added sync for os info (#985346)
..
etl: added sync for os info (#985346)
Change-Id: Ifb08524fa1b86b4367cf3e7281127be373f5c7a1
Bug-Url: https://bugzil
Yaniv Dary has posted comments on this change.
Change subject: etl: added sync for os info (#985346)
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19330
To unsubscribe, visit http://gerrit.
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: disk dialog - prevent scrollbars
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19336
To unsubscribe, visit http://gerrit.ovi
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: make template dialog - prevent scrollbars
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19335
To unsubscribe, visit http://g
Shubhendu Tripathi has posted comments on this change.
Change subject: restapi: Modified gluster volume rebalance action
..
Patch Set 6:
(2 comments)
Commit Message
Line 6:
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: allow reverting ssl config
..
Patch Set 7:
Rebased
--
To view, visit http://gerrit.ovirt.org/16769
To unsubscribe, visit http://gerrit.o
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: allow reverting ssl config
..
Patch Set 5:
(1 comment)
Commit Message
Line 7: packag
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: enhance line uninstall
..
Patch Set 6:
(4 comments)
File packaging/setup/plugins/ovi
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: fix for host getting removed when moved to
maintenance(#980750)
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19327
To
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Return UNKNOWN status for GlusterTaskStatus
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19308
To unsubscribe, visit ht
Greg Sheremeta has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1:
Ah, great point. The URL should absolutely be removed from AppConstants.
Thanks, I'll get to it :)
Einav Cohen has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1:
I was referring to ApplicationConstants, to which you have added an entry that
represents a path, rat
Eli Mesika has posted comments on this change.
Change subject: core: Adding job with auto_cleared false...
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19144
To unsubscribe, visit http://g
Eli Mesika has submitted this change and it was merged.
Change subject: core: Adding job with auto_cleared false...
..
core: Adding job with auto_cleared false...
Adding job with auto_cleared false, not working correct
v_is_au
Greg Sheremeta has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1:
sorry, I said "messages" and I meant "external_messages." As of right now, I
think everything is s
Einav Cohen has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1:
Thanks. As I said - no need to take care of that as part of this patch - we
will take care of that se
Einav Cohen has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1:
thanks for the clarification.
it is kind of problematic that we are mixing strings that should be tr
Greg Sheremeta has posted comments on this change.
Change subject: engine: updated out-of-date README.branding
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19340
To unsubscribe, visit http://gerrit.ovir
Einav Cohen has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1:
note that I am asking about the key, not the value.
[IIUC, the key should always be there, but if the
Greg Sheremeta has uploaded a new change for review.
Change subject: engine: updated out-of-date README.branding
..
engine: updated out-of-date README.branding
Added info to README.branding about some recent additions such as
ex
Greg Sheremeta has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1:
Two separate issues here.
First, key not being there == key being there and empty. Both conditions
Einav Cohen has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1:
maybe I am missing something, but shouldn't the new key be added to
"./packaging/branding/ovirt.brand
Daniel Erez has posted comments on this change.
Change subject: frontend: [JP] Resource allocation broken
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19326
To unsubscribe, visit http://gerrit.ovirt.
Greg Sheremeta has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19333
To unsubscribe, visit http://gerrit.ovi
Greg Sheremeta has posted comments on this change.
Change subject: engine: make documentation mapping brandable
..
Patch Set 1:
It's added to both -- but in oVirt, it's purposely missing from
external_resources (to prevent the
Greg Sheremeta has uploaded a new change for review.
Change subject: engine: make documentation mapping brandable
..
engine: make documentation mapping brandable
Move path of documentation mapping file into branding. This fixes
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3: Code-Review+1
I agree with Allon's comment on the class loading.
--
To view, visit http://gerrit.ovirt.org/18655
To
Greg Sheremeta has posted comments on this change.
Change subject: webadmin: overlapping event notification text
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19334
To unsubscribe, visit http://gerrit
Daniel Erez has posted comments on this change.
Change subject: frontend: make "any host in cluster" bigger
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19325
To unsubscribe, visit http://gerrit.ovir
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: disk dialog - prevent scrollbars
..
webadmin: disk dialog - prevent scrollbars
Adjusting style of 'New/Edit disk' dialog to
prevent redundant vertical/h
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: make template dialog - prevent scrollbars
..
webadmin: make template dialog - prevent scrollbars
Adjusting style of 'Make Template' dialog to
prevent re
Greg Sheremeta has posted comments on this change.
Change subject: engine: Add branded link to console resources
..
Patch Set 10:
Frank, I know this was already merged, but I noticed there are no fallbacks for
the values you a
Omer Frenkel has posted comments on this change.
Change subject: engine: Incorrect VM TimeZone handling
..
Patch Set 9: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17524
To unsubscribe, visit http://gerr
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Incorrect VM TimeZone handling
..
engine: Incorrect VM TimeZone handling
In case or running a VM from older engine installation it was possible
t
Yaniv Dary has uploaded a new change for review.
Change subject: etl: added sync for os info (#985346)
..
etl: added sync for os info (#985346)
Change-Id: Ifb08524fa1b86b4367cf3e7281127be373f5c7a1
Bug-Url: https://bugzilla.redha
Daniel Erez has posted comments on this change.
Change subject: engine: Split update of 'isPlugged' and 'bootOrder'
properties...
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19311
To unsubscribe, v
Eli Mesika has posted comments on this change.
Change subject: core: [TEXT] restore.sh woes, unable to...
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19329
To unsubscribe, visit http://gerrit.ovirt.or
Eli Mesika has uploaded a new change for review.
Change subject: core: [TEXT] restore.sh woes, unable to...
..
core: [TEXT] restore.sh woes, unable to...
[TEXT] restore.sh woes, unable to restore engine DB without using -u pos
Einav Cohen has posted comments on this change.
Change subject: engine: make LoginDomainComparator Serializable
..
Patch Set 3: Verified+1 Code-Review+2
Yair - many thanks for the prompt review!
merging.
--
To view, visit htt
Einav Cohen has submitted this change and it was merged.
Change subject: engine: make LoginDomainComparator Serializable
..
engine: make LoginDomainComparator Serializable
Make LoginDomainComparator Serializable to appease Cove
Allon Mureinik has submitted this change and it was merged.
Change subject: restapi: disk entity export to glance
..
restapi: disk entity export to glance
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=990962
Change-Id: I
Michael Pasternak has posted comments on this change.
Change subject: backend: add ActionGroup to access image domains
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18078
To unsubscribe, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Change VdsUpdateRuntimeInfo to work with BatchUpdates
..
Patch Set 2: Verified+1
Verified by manual testing of start/shutdown vm, and by other flow exe
Allon Mureinik has submitted this change and it was merged.
Change subject: backend: add ActionGroup to access image domains
..
backend: add ActionGroup to access image domains
Change-Id: Ifbff053962ae1dceef51c7d8ff356fcf527aa5
Allon Mureinik has posted comments on this change.
Change subject: backend: add ActionGroup to access image domains
..
Patch Set 6: Verified+1 Code-Review+2
Rebased, renamed upgrade script.
--
To view, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: restapi: disk entity export to glance
..
Patch Set 8: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/17541
To unsubsc
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Change VdsUpdateRuntimeInfo to work with BatchUpdates
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19274
To unsubscribe, vi
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : Change VdsUpdateRuntimeInfo to work with BatchUpdates
..
engine : Change VdsUpdateRuntimeInfo to work with BatchUpdates
Batch Updates greatly
Allon Mureinik has posted comments on this change.
Change subject: restapi: disk entity export to glance
..
Patch Set 7:
As discussed over email, the description was added to FeaturesHelper in
2df42d04.
--
To view, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Change VdsUpdateRuntimeInfo to work with BatchUpdates
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19274
To unsu
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: gluster volume rebalance status popup
..
Patch Set 35: Code-Review+2
minor comments.
--
To view, visit http://gerrit.ovirt.org/18328
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: backend: add ActionGroup to access image domains
..
Patch Set 5: Code-Review+2
Upgrading to +2 after Micahel gave +1 too.
--
To view, visit http://gerrit.ovir
Michael Pasternak has posted comments on this change.
Change subject: engine: Incorrect VM TimeZone handling
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17524
To unsubscribe, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: engine: make LoginDomainComparator Serializable
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19304
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: engine: make LoginDomainComparator Serializable
..
Patch Set 1: Verified+1 Code-Review+2
Thanks Greg!
--
To view, visit http://gerrit.ovirt.org/19304
To unsub
Tomas Jelinek has posted comments on this change.
Change subject: engine: Cache spice support for os/compatibility version
..
Patch Set 6: Code-Review+1
FE is still OK
--
To view, visit http://gerrit.ovirt.org/19137
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: engine: Cleanup of HotPlugDiskToVmCommand
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19302
To unsubscribe, visit http://gerrit.ovi
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: gluster volume rebalance status popup
..
Patch Set 35:
(8 comments)
minor comments, I'd have acked it but the change in ApplicationMessages.java
bugs
Frank Kobzik has posted comments on this change.
Change subject: engine: Cache spice support for os/compatibility version
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/19137
To unsubscribe, visit http://
Itamar Heim has posted comments on this change.
Change subject: core: remove VdcObjectType from ActionGroup enum
..
Patch Set 2:
i think we should consider finishing the feature rather than remove this?
iirc, it was about showi
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: enhance line uninstall
..
Patch Set 5:
(1 comment)
File packaging/setup/plugins/ovir
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: rebased to JRS CE 5.2
..
packaging: rebased to JRS CE 5.2
Change-Id: I837e1e99e40da1334fdc126ae410db1b24d3fed8
Signed-off-by: Yaniv Dary
---
M
Yaniv Dary has posted comments on this change.
Change subject: packaging: rebased to JRS CE 5.2
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19328
To unsubscribe, visit http://gerrit.ovirt
Tal Nisan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
Agreed, you just shed this info now so it makes sense not to use it
--
To view, visit http://gerrit.ovirt.org/18655
To un
Allon Mureinik has submitted this change and it was merged.
Change subject: frontend: display correct format in edit domain
..
frontend: display correct format in edit domain
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id
Allon Mureinik has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 5: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/19187
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: StorageVersionUtil fixes
..
engine: StorageVersionUtil fixes
Implemented several fixes:
* Do not fail attaching a domain if the storage format
Allon Mureinik has posted comments on this change.
Change subject: engine: StorageVersionUtil fixes
..
Patch Set 5: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/19193
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: engine: StorageVersionUtil fixes
..
Patch Set 4: Verified+1 Code-Review+2
Rebased, fixed nits as per Daniel's review.
--
To view, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 4: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/19187
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: enhance line uninstall
..
Patch Set 5: Verified+1
Verified http://gerrit.ovirt.org/16769 - ssl.conf
Rebased
Simplified code a bit by Alo
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: allow reverting ssl config
..
Patch Set 5: Verified+1
Rebased
--
To view, visit http://gerrit.ovirt.org/16769
To unsubscribe, visit http
Omer Frenkel has posted comments on this change.
Change subject: backend: Enable edit of VmTemplate OS
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19130
To unsubscribe, visit http://gerri
Omer Frenkel has submitted this change and it was merged.
Change subject: backend: Enable edit of VmTemplate OS
..
backend: Enable edit of VmTemplate OS
Added osId to list of permitted fields in VmTemplateHandler.
Change-Id: I
Allon Mureinik has posted comments on this change.
Change subject: engine: StorageVersionUtil fixes
..
Patch Set 3:
(2 comments)
File
backend/manager/modules/common/src/mai
Oved Ourfali has posted comments on this change.
Change subject: vdsm: use devices instead of drives in vm.conf
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19289
To unsubscribe, visit http://gerrit.
Tomas Jelinek has posted comments on this change.
Change subject: frontend: enable localization of usb support types
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19233
To unsubscribe, visit http://ge
Tomas Jelinek has posted comments on this change.
Change subject: frontend: enable localization of usb support types
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19233
To unsubscribe, visi
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: enable localization of usb support types
..
frontend: enable localization of usb support types
Change the translations of UsbPolicy enum value
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Removing not needed code
..
core: Removing not needed code
The following patch fixes redunant
host string calculation
Change-Id: Ia0270a2150e9d5
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removing not needed code
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19276
To unsubscribe, visit http://gerrit.ovi
Daniel Erez has posted comments on this change.
Change subject: engine: StorageVersionUtil fixes
..
Patch Set 3: Code-Review+2
(2 comments)
couple of minor comments
File
b
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: better illegal VM status message
..
core: better illegal VM status message
Enriched the "The VM status is illegal" message to contain
also the loc
Tomas Jelinek has posted comments on this change.
Change subject: core: better illegal VM status message
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19211
To unsubscribe, visit http://ger
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Add branded link to console resources
..
engine: Add branded link to console resources
This patch adds an external link to console resources (fo
Tomas Jelinek has posted comments on this change.
Change subject: engine: Add branded link to console resources
..
Patch Set 9: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18596
To unsubscribe, visit htt
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: remove bricks with migration support
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19201
To unsubscribe, visit http://gerrit
Tomas Jelinek has posted comments on this change.
Change subject: engine: Add branded link to console resources
..
Patch Set 10: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18596
To unsubscribe, visit ht
Yedidyah Bar David has posted comments on this change.
Change subject: build: post ovirt-hosted-engine-setup-1.0 branching
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19307
To unsubscribe, visit htt
Roy Golan has posted comments on this change.
Change subject: core: better illegal VM status message
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19211
To unsubscribe, visit http://gerrit.ovirt.org/s
Gilad Chaplik has posted comments on this change.
Change subject: core: fix findbugs issue for PolicyUnit.equals()
..
Patch Set 1:
cleans, thanks Alissa :)
--
To view, visit http://gerrit.ovirt.org/19285
To unsubscribe, visit
Tomas Jelinek has posted comments on this change.
Change subject: frontend: [JP] Resource allocation broken
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/19326
To unsubscribe, visit http://gerrit.ovirt.o
Tomas Jelinek has posted comments on this change.
Change subject: frontend: make "any host in cluster" bigger
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19325
To unsubscribe, visit http://gerrit.ovirt
Michael Pasternak has posted comments on this change.
Change subject: restapi: disk entity export to glance
..
Patch Set 7: Code-Review+2
*please add description to the FeaturesHelper*
--
To view, visit http://gerrit.ovirt.or
Tomas Jelinek has uploaded a new change for review.
Change subject: frontend: make "any host in cluster" bigger
..
frontend: make "any host in cluster" bigger
In french locale it was broken into 2 lines. The
width: 150px did not
Tomas Jelinek has uploaded a new change for review.
Change subject: frontend: [JP] Resource allocation broken
..
frontend: [JP] Resource allocation broken
In new/edit/clone VM the resource allocation tab's layout was broken.
Si
Yedidyah Bar David has posted comments on this change.
Change subject: build: post ovirt-hosted-engine-setup-1.0 branching
..
Patch Set 2:
(1 comment)
File configure.ac
Line
Yedidyah Bar David has posted comments on this change.
Change subject: build: post ovirt-hosted-engine-setup-1.0.0-0.4.beta
..
Patch Set 1: Code-Review+1
(1 comment)
Commit
Omer Frenkel has posted comments on this change.
Change subject: engine: Incorrect VM TimeZone handling
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17524
To unsubscribe, visit http://gerrit.ovirt.or
Michael Pasternak has posted comments on this change.
Change subject: restapi: disk entity export to glance
..
Patch Set 6:
1. missing tests at BackendStorageDomainDiskResourceTest
2. please also add to all test classes: testB
1 - 100 of 142 matches
Mail list logo
