Greg Sheremeta has posted comments on this change. Change subject: engine: Add branded link to console resources ......................................................................
Patch Set 10: Frank, I know this was already merged, but I noticed there are no fallbacks for the values you added. See ApplicationDynamicMessages for an example. The fallbacks are designed so that at least something is present if the brand package is missing. They are optional, but recommended. See README.branding for a detailed explanation of adding messages, including fallbacks, to branding. -- To view, visit http://gerrit.ovirt.org/18596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f7316e6ce5032123edc2e39b4939d0c8dab1cb1 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
