Einav Cohen has posted comments on this change. Change subject: engine: make documentation mapping brandable ......................................................................
Patch Set 1: maybe I am missing something, but shouldn't the new key be added to "./packaging/branding/ovirt.brand/external_resources.properties" (instead of ApplicationConstants)? [looking at http://gerrit.ovirt.org/#/c/18146/ for comparison; note that it was merged before introducing external_resources.properties IIRC] Thanks. -- To view, visit http://gerrit.ovirt.org/19333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1eeb58f8293be21e33b60030d2720fb9dc39140e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
