Einav Cohen has posted comments on this change. Change subject: engine: make documentation mapping brandable ......................................................................
Patch Set 1: note that I am asking about the key, not the value. [IIUC, the key should always be there, but if the value is empty - we shouldn't try to retrieve the file, hence we won't get the 404] what I am trying to understand is why was the "docMappingFile" entry added to ApplicationConstants; in similar cases [e.g. http://gerrit.ovirt.org/#/c/18146/ (guide link branding)], nothing was added to ApplicationConstants, but was added to external_resources.properties (well, to messages.properties which was later split into external_resources.properties). Thanks. -- To view, visit http://gerrit.ovirt.org/19333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1eeb58f8293be21e33b60030d2720fb9dc39140e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
