Greg Sheremeta has posted comments on this change.
Change subject: engine: make documentation mapping brandable
......................................................................
Patch Set 1:
Two separate issues here.
First, key not being there == key being there and empty. Both conditions are
checked for and are treated the same. It's probably clearer to have an empty
key, so I will change it. (But either way, 404 gets prevented.)
Second, the things added to ApplicationConstants are fallback values only.
They're used if the brand package is missing. The only reason you don't see it
in the Guide link commit is that it was already there!
@DefaultStringValue("Guide")
String guideLinkLabel();
So, you are right, the key should be in both places. messages for the brand
value, AppConstants for the fallback.
--
To view, visit http://gerrit.ovirt.org/19333
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1eeb58f8293be21e33b60030d2720fb9dc39140e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
