Yedidyah Bar David has posted comments on this change. Change subject: build: post ovirt-hosted-engine-setup-1.0 branching ......................................................................
Patch Set 2: (1 comment) .................................................... File configure.ac Line 25: define([VERSION_SUFFIX], [_master]) Line 26: Line 27: AC_INIT([ovirt-hosted-engine-setup], VERSION_NUMBER[]VERSION_SUFFIX) Line 28: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 29: PACKAGE_RPM_RELEASE="0.0.$(echo VERSION_SUFFIX | sed 's/^_//')" Why did you change '0.5.' to '0.0.'? What will happen with someone that e.g. uses nightly builds and tried the beta? Will they get newer nightlies? Line 30: PACKAGE_MAVEN_VERSION="VERSION_MAJOR.VERSION_MINOR.0$(echo VERSION_SUFFIX | sed 's/^_/-/')" Line 31: AC_SUBST([PACKAGE_RPM_VERSION]) Line 32: AC_SUBST([PACKAGE_RPM_RELEASE]) Line 33: AC_SUBST([PACKAGE_MAVEN_VERSION]) -- To view, visit http://gerrit.ovirt.org/19307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I922f3a9e44a561d85a78d9d9612611d595cd1122 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
