Einav Cohen has posted comments on this change. Change subject: engine: make documentation mapping brandable ......................................................................
Patch Set 1: thanks for the clarification. it is kind of problematic that we are mixing strings that should be translated with strings that shouldn't be translated; that's why we have separations such as messages vs. external_resources, Enums vs. LocalizedEnums, etc. it doesn't have to be taken care of in this patch, but we should consider splitting strings that shouldn't be translated out of our existing .properties files and into separate .properties files (not sure how many strings like that we actually have). -- To view, visit http://gerrit.ovirt.org/19333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1eeb58f8293be21e33b60030d2720fb9dc39140e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
