Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
Because the "new VM dialog" will contain a part where you will be able to
select a NIC and assign it to a logical net
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: Introducing findbugs filter to bll module
..
Patch Set 3:
Laszlo,
Care to respond, so we can advance with this?
--
To view, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: tools: enable unit tests
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14271
To unsubscribe, visit h
Liron Ar has posted comments on this change.
Change subject: core: inactive domain can be selected as master
..
Patch Set 5:
Michael, thanks for your review.
can you please elaborate on few raised issues -
"The patch will ca
Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: branding support.
..
Patch Set 11:
The exception I got was due to I37156061cbdd.
--
To view, visit http://gerrit.ovirt.org/13181
To unsubsc
Alon Bar-Lev has posted comments on this change.
Change subject: core: re-support broken apache proxy
..
Patch Set 1: Verified
Hi,
In future, please test changes that may effect setup using production product
setup aka instal
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: re-support broken apache proxy
..
core: re-support broken apache proxy
apache proxy support was broken in:
I37156061cbdd, 'core: i18n splash screen.'
The
Alon Bar-Lev has posted comments on this change.
Change subject: core: rhevm-upgrade creates log/helping files...
..
Patch Set 1: Looks good to me, but someone else must approve
Thanks!
--
To view, visit http://gerrit.ovirt.or
Moti Asayag has posted comments on this change.
Change subject: gluster: Override CommandBase.getJobMessageProperties
..
Patch Set 4:
Shireesh, may I ask you to verify the patch as I don't have gluster installed
on my environm
Daniel Erez has posted comments on this change.
Change subject: webadmin: Making VM related substabs resizable
..
Patch Set 1: (2 inline comments)
File
frontend/webadmin/mod
Project: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/49/
Build Number: 49
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Daniel Erez has posted comments on this change.
Change subject: findbugs: Method with Boolean return explicit null
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14227
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Host Tab - "Primary" & "Secondary" are not localized
..
webadmin: Host Tab - "Primary" & "Secondary" are not localized
These strings were hard
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Host Tab - "Primary" & "Secondary" are not localized
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1429
Daniel Erez has posted comments on this change.
Change subject: webadmin: Host Tab - "Primary" & "Secondary" are not localized
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14295
To unsubs
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: move all packaging related to packaging
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14302
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: move all packaging related to packaging
..
packaging: move all packaging related to packaging
currently we manage packaging scripts all over the tree,
Michael Pasternak has uploaded a new change for review.
Change subject: cli: do not use preserved "type" as param name
..
cli: do not use preserved "type" as param name
Change-Id: If709df3d9c63ae77c19f2b52cad27e5490b46481
Signed
Michael Pasternak has uploaded a new change for review.
Change subject: cli: remove pexpect dependency
..
cli: remove pexpect dependency
GetKeyCommand is a deprecated POC that no longer maintained/supported,
since pexpect was fo
Michael Pasternak has uploaded a new change for review.
Change subject: cli: normalize sdk errors
..
cli: normalize sdk errors
Change-Id: Ia4fef4767f7c007ae882c3734b592ab63b32deb5
Signed-off-by: Michael pasternak
---
M src/cli/
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: JP - truncation in interface column
..
webadmin: JP - truncation in interface column
Attach Disk:
fix columns headers truncation
Change-Id: Iee
Daniel Erez has posted comments on this change.
Change subject: webadmin: JP - truncation in interface column
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14287
To unsubscribe,
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
Hi Tomas,
I don't really understand why do you need builders here.
Why can't you use the current models for the instan
Eli Mesika has posted comments on this change.
Change subject: core: rhevm-upgrade creates log/helping files...
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14298
To unsubscribe, visit http://gerrit.ovirt.
Eli Mesika has uploaded a new change for review.
Change subject: core: rhevm-upgrade creates log/helping files...
..
core: rhevm-upgrade creates log/helping files...
rhevm-upgrade creates log/helping files in /usr/share/ovirt-en
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Host Tab - "Primary" & "Secondary" are not localized
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14295
To unsubscribe, visit http
Michael Pasternak has uploaded a new change for review.
Change subject: cli: recognize AmbiguousQueryError as COMMAND_ERROR
..
cli: recognize AmbiguousQueryError as COMMAND_ERROR
Change-Id: I61665beffe059b3ebe2296ebb4916bfe49f1f
Allon Mureinik has posted comments on this change.
Change subject: findbugs: String comparison is not using equals method
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: tools: enable unit tests
..
Patch Set 1:
@Alon - unfortunately, not
:-(
--
To view, visit http://gerrit.ovirt.org/14271
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Remove VM comparators in Common.gwt.xml
..
webadmin: Remove VM comparators in Common.gwt.xml
Removed VmsComparer's and VmsComparerByDiskSize
Allon Mureinik has submitted this change and it was merged.
Change subject: core: unify and move Disk Comparators
..
core: unify and move Disk Comparators
Organized the various Disk and DiskImage comparators in a sensible
manne
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Introducing the comparators package
..
core: Introducing the comparators package
org.ovirt.engine.core.common.businessentities includes several
c
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Remove VM comparators in Common.gwt.xml
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14285
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: Introducing the comparators package
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14192
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: core: unify and move Disk Comparators
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13849
To unsubscribe, visi
Allon Mureinik has posted comments on this change.
Change subject: findbugs: equals between different types
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14296
To unsu
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: equals between different types
..
findbugs: equals between different types
Change-Id: I125e5df8def7a223f9469decc7aa43dab61f4a47
Signed-off-by: Shahar
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Host Tab - "Primary" & "Secondary" are not localized
..
webadmin: Host Tab - "Primary" & "Secondary" are not localized
These strings were hard coded in
Alon Bar-Lev has posted comments on this change.
Change subject: findbugs: self comparison of user to itself
..
Patch Set 1: Looks good to me, but someone else must approve
Thanks!
I looked several times on the findbugs, and I
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Remove VM comparators in Common.gwt.xml
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal.
--
To view, visit h
Allon Mureinik has posted comments on this change.
Change subject: core: Introducing the comparators package
..
Patch Set 4: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Yair.
--
To view, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: unify and move Disk Comparators
..
Patch Set 9: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Maor.
--
To view, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: findbugs: toString may return null
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14294
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Method with Boolean return explicit null
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/142
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disk dialog - capitalize labels
..
webadmin: Disk dialog - capitalize labels
New/Edit disk dialog:
s/Is bootable/Is Bootable
s/Is shareable/Is S
Allon Mureinik has posted comments on this change.
Change subject: findbugs: self comparison of user to itself
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14293
To u
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disk dialog - capitalize labels
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14281
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disks VMs Templates sub-tabs resizable columns
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14280
To un
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: toString may return null
..
findbugs: toString may return null
Change-Id: I7540e6cfadb76f742f5b9959418b5e0a6cbf4fed
Signed-off-by: Shahar Havivi
---
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disks VMs Templates sub-tabs resizable columns
..
webadmin: Disks VMs Templates sub-tabs resizable columns
VMs/Templates sub-tabs under Disks ma
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: ISO/Export sub-tabs resizable columns
..
webadmin: ISO/Export sub-tabs resizable columns
ISO/Export sub-tabs under Storage main-tab
now support
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: self comparison of user to itself
..
findbugs: self comparison of user to itself
Change-Id: Ifa88e752da82043857f27d334ba86ca1c5587bcd
Signed-off-by: S
Daniel Erez has posted comments on this change.
Change subject: webadmin: ISO/Export sub-tabs resizable columns
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14279
To unsubscribe
Michael Pasternak has posted comments on this change.
Change subject: restapi: disabling POST & DELETE implementations for quota
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14046
To unsu
Doron Fediuck has posted comments on this change.
Change subject: restapi: disabling POST & DELETE implementations for quota
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing the comparators package
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14192
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing the comparators package
..
Patch Set 3:
Well done.
--
To view, visit http://gerrit.ovirt.org/14192
To unsubscribe, visit http://gerrit.ovirt.
Maor Lipchuk has posted comments on this change.
Change subject: core: Introducing the comparators package
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14192
To unsubscribe, visit http://
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/
Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/748/
Build Number: 748
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Maor Lipchuk has posted comments on this change.
Change subject: webadmin: Remove VM comparators in Common.gwt.xml
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14285
Maor Lipchuk has posted comments on this change.
Change subject: core: unify and move Disk Comparators
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13849
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: Revert "engine: Use isBlockDomain() where possible"
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14292
To unsubscribe, visit http://gerrit
Allon Mureinik has uploaded a new change for review.
Change subject: Revert "engine: Use isBlockDomain() where possible"
..
Revert "engine: Use isBlockDomain() where possible"
This is a partial revert of the rest parts of commit
Arik Hadas has uploaded a new change for review.
Change subject: core: [WIP] ram snapshots related changes in bll project
..
core: [WIP] ram snapshots related changes in bll project
Change-Id: Ifbb28efda1b63e506233a88399488a256e
Arik Hadas has uploaded a new change for review.
Change subject: core: [WIP] extract general code from HibernateVmCommand
..
core: [WIP] extract general code from HibernateVmCommand
This patch extract code which is not specific
Maor Lipchuk has submitted this change and it was merged.
Change subject: webadmin: new pool - update disks list on template change
..
webadmin: new pool - update disks list on template change
Ensure that IsDiskAvailable event
Maor Lipchuk has posted comments on this change.
Change subject: webadmin: new pool - update disks list on template change
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14286
To
Maor Lipchuk has posted comments on this change.
Change subject: webadmin: new pool - update disks list on template change
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14286
To unsubscribe, visit http://ge
Asaf Shakarchi has uploaded a new change for review.
Change subject: build: Explicit versions definitions for maven plugins.
..
build: Explicit versions definitions for maven plugins.
Maven 3.x deprecates definition of plugins a
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: Field masks field in superclass
..
findbugs: Field masks field in superclass
Change-Id: I544d5e4e602040c70020fa9b2c43a49ad0bbcb9d
Signed-off-b
Shahar Havivi has posted comments on this change.
Change subject: findbugs: Field masks field in superclass
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14197
To unsubscribe, vi
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding parameters to delay fence based on host's load
..
Adding parameters to delay fence based on host's load
Before performing fencing to host, we wait Timeo
Ori Liel has submitted this change and it was merged.
Change subject: restapi: #920483 - Group Wrongly Displayed as User (within
permission)
..
restapi: #920483 - Group Wrongly Displayed as User (within permission)
Change-Id:
Ori Liel has posted comments on this change.
Change subject: restapi: #920483 - Group Wrongly Displayed as User (within
permission)
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Daniel Erez has posted comments on this change.
Change subject: webadmin: new pool - update disks list on template change
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14286
To unsubscribe
Alona Kaplan has posted comments on this change.
Change subject: webadmin: JP - truncation in interface column
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14287
To unsubscribe, visit htt
Moti Asayag has posted comments on this change.
Change subject: webadmin: Suggest an action when network is out of sync
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14282
To uns
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Suggest an action when network is out of sync
..
webadmin: Suggest an action when network is out of sync
Change-Id: I21bccd87bf1311f6d2d87683f1f
Ayal Baron has posted comments on this change.
Change subject: core: Mount options not sent when adding POSIX domain
..
Patch Set 1:
Could the underlying issue simply be an upgrade issue? i.e. AdvancedNFSOptions
was not set pr
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/
Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/743/
Build Number: 743
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Tal Nisan has posted comments on this change.
Change subject: webadmin: Remove VM comparators in Common.gwt.xml
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14285
To unsubscribe, visit ht
Tal Nisan has posted comments on this change.
Change subject: webadmin: Disk dialog - capitalize labels
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14281
To unsubscribe, visit http://ger
Tal Nisan has posted comments on this change.
Change subject: webadmin: ISO/Export sub-tabs resizable columns
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14279
To unsubscribe, visit http
Tal Nisan has posted comments on this change.
Change subject: webadmin: Disks VMs Templates sub-tabs resizable columns
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14280
To unsubscribe, v
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: JP - truncation in interface column
..
webadmin: JP - truncation in interface column
Attach Disk:
fix columns headers truncation
Change-Id: Ieee042d7ef
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: make cpu-mode enumerable values lower-case #915042
..
restapi: make cpu-mode enumerable values lower-case #915042
Change-Id: I50623ebbc1ec7
Michael Pasternak has posted comments on this change.
Change subject: restapi: make cpu-mode enumerable values lower-case #915042
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14
Alona Kaplan has posted comments on this change.
Change subject: webadmin: quota - subtabs resizable columns
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14278
To unsubscribe, visit http:
Maor Lipchuk has uploaded a new change for review.
Change subject: webadmin: new pool - update disks list on template change
..
webadmin: new pool - update disks list on template change
Ensure that IsDiskAvailable event sent on
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Suggest an action when network is out of sync
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14282
To unsubscribe,
Liron Ar has posted comments on this change.
Change subject: core: wip: initVdsOnUp- remove reconstruct and host status.
..
Patch Set 9: (1 inline comment)
File
backend/mana
Omer Frenkel has posted comments on this change.
Change subject: engine: fetch gluster host uuid during InitVdsOnUp
..
Patch Set 3: (2 inline comments)
File
backend/manager/
Michael Kublin has posted comments on this change.
Change subject: core: InitVdsOnUp- proceed regardless of
ConnectHostToStoragePoolServers
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Bad au
Michael Kublin has posted comments on this change.
Change subject: core: wip: initVdsOnUp- remove reconstruct and host status.
..
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
.
Omer Frenkel has posted comments on this change.
Change subject: webadmin: Correct timezone default in New/Edit VM dialog
..
Patch Set 1: (1 inline comment)
also, if we want the users to be able to modify the new configuration
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: log rotation - do not execute ls on non-existing
files
..
packaging: log rotation - do not execute ls on non-existing files
Due to the usag
Ofer Schreiber has posted comments on this change.
Change subject: packaging: log rotation - do not execute ls on non-existing
files
..
Patch Set 4: Verified; Looks good to me, approved
Based on own verification and Sandro's +
Ofer Schreiber has posted comments on this change.
Change subject: packaging: log rotation - do not execute ls on non-existing
files
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14097
To
Allon Mureinik has posted comments on this change.
Change subject: core: unify and move Disk Comparators
..
Patch Set 8: Verified
Changes in previous patch in the series, no changes to this one.
--
To view, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 11: Looks good to me, but someone else must approve
Sorry for the noise. Rebase patch#9, nothing changed.
--
1 - 100 of 157 matches
Mail list logo
