Michael Kublin has posted comments on this change.
Change subject: core: wip: initVdsOnUp- remove reconstruct and host status.
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 183: new
ConnectStoragePoolVDSCommandParameters(vds.getId(), storagePoolId,
Line 184: vds.getVdsSpmId(), masterDomain.getId(),
Line 185:
storagePool.getmaster_domain_version())).getSucceeded();
Line 186: } catch (VdcBLLException e) {
Line 187: if (e.getErrorCode() != VdcBllErrors.VDS_NETWORK_ERROR &&
First of all Liron, do you think this code is good?
It is answers to criteria keep it simple? And we are talking about 4 lines....
This code contains internal race, that's why it is wrong.
Also, patch can not be good if it should be fixed after that.
Line 188: e.getErrorCode() != VdcBllErrors.PROTOCOL_ERROR
Line 189: && (masterDomain.getStatus() ==
StorageDomainStatus.InActive
Line 190: || masterDomain.getStatus() ==
StorageDomainStatus.Unknown)) {
Line 191: shouldProceedVdsStats = false;
--
To view, visit http://gerrit.ovirt.org/13709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6418b9d2826146e1e4ceff4341c6d7cd3a0024af
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
