Omer Frenkel has posted comments on this change.
Change subject: engine: fetch gluster host uuid during InitVdsOnUp
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 63: public class InitVdsOnUpCommand extends
StorageHandlingCommandBase<HostStoragePoolParametersBase> {
Line 64: private boolean _fenceSucceeded = true;
Line 65: private boolean _vdsProxyFound;
Line 66: private boolean _connectStorageSucceeded, _connectPoolSucceeded;
Line 67: private boolean _glusterHostUuidFound, _glusterPeerListSucceeded,
_glusterPeerProbeSucceeded;
please use java convention, no need for underline ('_') before members names,
i see other are wrong but no reason to stick with wrong behavior..
Line 68: private FenceStatusReturnValue _fenceStatusReturnValue;
Line 69:
Line 70: public InitVdsOnUpCommand(HostStoragePoolParametersBase
parameters) {
Line 71: super(parameters);
Line 256: } else if (getVds().getpm_enabled() && !_fenceSucceeded) {
Line 257: type = AuditLogType.VDS_FENCE_STATUS_FAILED;
Line 258: }
Line 259:
Line 260: // PM alerts
not sure PM alerts should be inside the 'if' statement, i think its relevant
for gluster as well..
Line 261: AuditLogableBase logable = new
AuditLogableBase(getVds().getId());
Line 262: if (getVds().getpm_enabled()) {
Line 263: if (!_vdsProxyFound) {
Line 264: logable.addCustomValue("Reason",
--
To view, visit http://gerrit.ovirt.org/14166
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied8e8b006adc5722cd70ee19d75a4b6f783d5f44
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
