Alona Kaplan has posted comments on this change. Change subject: webadmin: Network builders ......................................................................
Patch Set 4: Hi Tomas, I don't really understand why do you need builders here. Why can't you use the current models for the instance types. Why are instance types so special? Why can't they be part or extension of the existing hierarchy? I think that the use of the builders in this patch makes the code less readable. I know the code of the models in the patch very well and it was hard for me to understand the flow with the new code:) -- To view, visit http://gerrit.ovirt.org/13918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icae2963687ad7978c3caa026e7062e7a1937d320 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
