Daniel Erez has posted comments on this change. Change subject: webadmin: Making VM related substabs resizable ......................................................................
Patch Set 1: (2 inline comments) .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskTemplateView.java Line 34: initWidget(getTable()); Line 35: } Line 36: Line 37: void initTable(ApplicationConstants constants) { Line 38: getTable().enableColumnResizing(); already fixed in http://gerrit.ovirt.org/#/c/14280/ Line 39: Line 40: TextColumnWithTooltip<VmTemplate> nameColumn = new TextColumnWithTooltip<VmTemplate>() { Line 41: @Override Line 42: public String getValue(VmTemplate object) { .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java Line 37: initWidget(getTable()); Line 38: } Line 39: Line 40: void initTable(final ApplicationConstants constants) { Line 41: getTable().enableColumnResizing(); already fixed in http://gerrit.ovirt.org/#/c/14280/ Line 42: Line 43: ImageResourceColumn<VM> pluggedColumn = new ImageResourceColumn<VM>() { Line 44: @Override Line 45: public ImageResource getValue(VM object) { -- To view, visit http://gerrit.ovirt.org/14253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8a7edcf437650a4882d767f29ce5041f3b3be6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches