Liron Ar has posted comments on this change. Change subject: core: inactive domain can be selected as master ......................................................................
Patch Set 5: Michael, thanks for your review. can you please elaborate on few raised issues - "The patch will cause insufficient reconstructs in 99%" - in which cases? can you please give example for such case? "Idea is wrong, why? If no Active/Unknown domain in pool, meaning we have not any host that can see it, no reason for reconstruct" - that's exactly the issue, when hosts aren't connected to the pool - we can't recover the domains from being inactive to be active - the behaviour that we want in the system is to attempt to reconstruct to those inactive domains. "If host is not connected to pool or failed to connect, during spm election we can trigger a reconstruct on InActive domains, but code should look differently" - I don't agree, reconstruct is triggered from irs commands when we get IRSNoMasterDomainException, the logic is to first reconstruct to active/unknown domains and only if there's not such one attempt to do it for inactive domains - the fact that the same master can't be chosen to be reconstructed to is another issue that we have unrelated to this change. -- To view, visit http://gerrit.ovirt.org/13160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9031e2fe0afc161c1a3acdddc9b1e7a58626a159 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
