Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Host Tab - "Primary" & "Secondary" are not localized ......................................................................
webadmin: Host Tab - "Primary" & "Secondary" are not localized These strings were hard coded in the host model. Moved to the Constants file. Change-Id: Ib339264fb776c5e9b060068c40f0a9d15372fe41 Bug-Url: https://bugzilla.redhat.com/952083 Signed-off-by: Alona Kaplan <alkap...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/95/14295/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java index 255125a..1f2c61f 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java @@ -669,8 +669,8 @@ setPmVariants(new ListModel()); List<String> pmVariants = new ArrayList<String>(); - pmVariants.add("Primary"); //$NON-NLS-1$ - pmVariants.add("Secondary"); //$NON-NLS-1$ + pmVariants.add(ConstantsManager.getInstance().getConstants().primaryPmVariant()); + pmVariants.add(ConstantsManager.getInstance().getConstants().secondaryPmVariant()); getPmVariants().setItems(pmVariants); getPmVariants().setSelectedItem(pmVariants.get(0)); diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java index f1a96a7..e68241f 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java @@ -1826,4 +1826,10 @@ @DefaultStringValue("SMT Enabled") String smtEnabled(); + + @DefaultStringValue("Primary") + String primaryPmVariant(); + + @DefaultStringValue("Secondary") + String secondaryPmVariant(); } -- To view, visit http://gerrit.ovirt.org/14295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib339264fb776c5e9b060068c40f0a9d15372fe41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
