Kanagaraj M has posted comments on this change.
Change subject: engine: Enable gluster hook on cluster
..
Patch Set 10: (4 inline comments)
File
backend/manager/modules/bll/
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: cleanup: favor Charset.getName() over plain string
..
pki: cleanup: favor Charset.getName() over plain string
Change-Id: Id61cad58356820a73683666235d328a725
Alon Bar-Lev has uploaded a new change for review.
Change subject: host-deploy: cleanup: favor Charset.getName() over plain string
..
host-deploy: cleanup: favor Charset.getName() over plain string
Change-Id: Ifa209cebf9efa5dc6c
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup: Found reliance on default encoding
..
Patch Set 1: (2 inline comments)
File
backend/manager/mo
Alissa Bonas has posted comments on this change.
Change subject: pki: cleanup: Found reliance on default encoding
..
Patch Set 1: (3 inline comments)
File
backend/manager/mo
Alon Bar-Lev has uploaded a new change for review.
Change subject: host-deploy: cleanup: remove unused VdsInstallStages
..
host-deploy: cleanup: remove unused VdsInstallStages
Change-Id: Ibeecb987720428dd0bd515884dde8e6a198159a2
Maor Lipchuk has posted comments on this change.
Change subject: core: Removed the unused GetImageByImageIdQuery
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/mo
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: cleanup: Format string should use %n rather than \n
..
pki: cleanup: Format string should use %n rather than \n
Workaround to quiet findbugs... we do need \
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: cleanup: Found reliance on default encoding
..
pki: cleanup: Found reliance on default encoding
Change-Id: I181c9b3e26c5b941fe368b3287a7486b6b8f91e1
Signed-
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: cleanup: the method name SignCertificateRequest doesn't
start with a lower case letter
..
pki: cleanup: the method name SignCertificateRequest doesn't start
Alon Bar-Lev has uploaded a new change for review.
Change subject: host-deploy: cleanup: A class's finalize() method should have
protected access, not public.
..
host-deploy: cleanup: A class's finalize() method should have prot
Alon Bar-Lev has uploaded a new change for review.
Change subject: host-deploy: cleanup: Redundant nullcheck of vdsByUniqueId
..
host-deploy: cleanup: Redundant nullcheck of vdsByUniqueId
Change-Id: Idd6454026bfa210c382d1e20d5c6
Alon Bar-Lev has uploaded a new change for review.
Change subject: host-deploy: cleanup: Incorrect lazy initialization of static
field VdsDeploy.s_deployPackage
..
host-deploy: cleanup: Incorrect lazy initialization of static fi
Alon Bar-Lev has uploaded a new change for review.
Change subject: host-deploy: cleanup: Exception is caught when Exception is not
thrown
..
host-deploy: cleanup: Exception is caught when Exception is not thrown
Change-Id: I469
Daniel Erez has posted comments on this change.
Change subject: core: unify the GetAllImagesList queries
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13066
To unsubsc
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: No need for gwt-plugin.extraJvmArgs in
gwt-extension
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http:/
Daniel Erez has posted comments on this change.
Change subject: frontend: Use console popup dialog in webadmin
..
Patch Set 1: (6 inline comments)
File
frontend/webadmin/mod
Alon Bar-Lev has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
This discussion is closed.
I heard the complex arguments, and I reject them.
Please do not make any
Yair Zaslavsky has uploaded a new change for review.
Change subject: [WIP] core: template can't be seen by user
..
[WIP] core: template can't be seen by user
The user_vm_template_permissions_view_base has a bug -
for the case us
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Don't generate .jar.index files
..
packaging: Don't generate .jar.index files
The service has already been modified so that it doesn't use t
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't generate .jar.index files
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13179
To unsubscribe, visit http
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't generate .jar.index files
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13179
To unsubscribe, visit http://gerrit.ovirt.or
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Don't generate .index.jar files
..
packaging: Don't generate .index.jar files
The service has already been modified so that it doesn't use the
.inde
Doron Fediuck has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1: Looks good to me, but someone else must approve
I agree there is an issue or at least unconvinced the
Alona Kaplan has uploaded a new change for review.
Change subject: engine: Remove migration role from old migration network
..
engine: Remove migration role from old migration network
Cluster can contain only one migration netwo
Alona Kaplan has uploaded a new change for review.
Change subject: restapi: Adding "MIGRATION" role as a network usage.
..
restapi: Adding "MIGRATION" role as a network usage.
Migration role on a NetworkCluster indicates the mig
Sharad Mishra has uploaded a new change for review.
Change subject: core: Set AdvancedNFSOptionsEnabled for compat version 3.3.
..
core: Set AdvancedNFSOptionsEnabled for compat version 3.3.
To enable glusterfs in version 3.3,
Sharad Mishra has abandoned this change.
Change subject: engine: Set mnt_option, vfsType for glusterfs.
..
Patch Set 1: Abandoned
in favor of http://gerrit.ovirt.org/#/c/13176/
--
To view, visit http://gerrit.ovirt.org/13155
Eli Mesika has posted comments on this change.
Change subject: core:There is no notification on event tab...
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13174
To unsubscribe, visit http://gerrit.ovirt.org
Eli Mesika has posted comments on this change.
Change subject: core:There is no notification on event tab about...
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13175
To unsubscribe, visit http://gerrit.ovi
Eli Mesika has uploaded a new change for review.
Change subject: core:There is no notification on event tab about...
..
core:There is no notification on event tab about...
There is no notification on event tab about what proxy i
Eli Mesika has uploaded a new change for review.
Change subject: core:There is no notification on event tab...
..
core:There is no notification on event tab...
There is no notification on event tab about what proxy is selected t
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: No need to override
gwt-plugin.extraJvmArgs in gwt-extension
..
webadmin,userportal: No need to override gwt-plugin.extraJvmArgs in
gwt-ex
Hello ofri masad,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/13172
to review the following change.
Change subject: core: Fix for VmBase
..
core: Fix for VmBase
Fix for patch: I9ccb4fc0b807c77b
Doron Fediuck has posted comments on this change.
Change subject: core: moving sla logic to sla package (6/X)
..
Patch Set 1:
Another nit: please move VdsLoadBalancer into scheduling and from backend init
the quartz init part
Doron Fediuck has posted comments on this change.
Change subject: core: moving sla logic to sla package (6/X)
..
Patch Set 1:
Not reviewed yet, but as an initial step please change namespace from sla to
scheduling.
--
To view
Roy Golan has posted comments on this change.
Change subject: core: on handing over a VM mark it as MigratingTo
..
Patch Set 3: Verified; No score
--
To view, visit http://gerrit.ovirt.org/13040
To unsubscribe, visit http://ger
Roy Golan has posted comments on this change.
Change subject: core: on handing over a VM mark it as MigratingTo
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13040
To unsubscribe, visit ht
Ravi Nori has posted comments on this change.
Change subject: cli: Ping command success message need to be rephrased(#918749)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12840
To unsubscribe, visit http:/
Ravi Nori has restored this change.
Change subject: cli: Ping command success message need to be rephrased(#918749)
..
Patch Set 1: Restored
Will update patch
--
To view, visit http://gerrit.ovirt.org/12840
To unsubscribe, vis
Mark Wu has posted comments on this change.
Change subject: core: Allow creating ISO domain on other file-based storages
except nfs
..
Patch Set 3: (1 inline comment)
File
Mark Wu has posted comments on this change.
Change subject: core: Allow creating ISO domain on other file-based storages
except nfs
..
Patch Set 4:
Hi Allon,
Sorry, I still can't understand your last comment after looking at
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remove unused VmPayload constructor
..
Patch Set 2:
fixed commit msg
--
To view, visit http://gerrit.ovirt.org/13161
To unsubscribe, visit http://gerri
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remove SimpleJdbcTemplate
..
Patch Set 2:
nothing new, rebased
--
To view, visit http://gerrit.ovirt.org/13157
To unsubscribe, visit http://gerrit.ovir
Laszlo Hornyak has posted comments on this change.
Change subject: engine: replace ParameterizedRowMapper
..
Patch Set 2:
nothing new, rebased
--
To view, visit http://gerrit.ovirt.org/13150
To unsubscribe, visit http://gerrit
Eli Mesika has submitted this change and it was merged.
Change subject: packaging: update version of postgresql driver
..
packaging: update version of postgresql driver
For some reason the 9.1-901.jdbc4 downloads 9.0 driver, ma
Eli Mesika has posted comments on this change.
Change subject: packaging: update version of postgresql driver
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12790
To unsubscribe,
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remoce unused VmPayload constructor
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: Autho
Eli Mesika has posted comments on this change.
Change subject: packaging: update version of postgresql driver
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12790
To unsubscribe,
Eli Mesika has posted comments on this change.
Change subject: packaging: Updated parsing of the tasks
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13131
To unsubscri
Alon Bar-Lev has posted comments on this change.
Change subject: tools: added rpm to hypervisors sosreport
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13169
To unsub
Sandro Bonazzola has posted comments on this change.
Change subject: tools: added rpm to hypervisors sosreport
..
Patch Set 2: (1 inline comment)
File src/__main__.py
Line 53
Sandro Bonazzola has posted comments on this change.
Change subject: tools: added rpm to hypervisors sosreport
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13169
To unsubscribe, visit http://gerrit.ovirt.o
Eli Mesika has posted comments on this change.
Change subject: engine: remoce unused VmPayload constructor
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Decouple AspectJ config from
gwt-plugin.extraJvmArgs
..
webadmin,userportal: Decouple AspectJ config from gwt-plugin.extraJvmArgs
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Decouple AspectJ config from
gwt-plugin.extraJvmArgs
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Decouple AspectJ config from
gwt-plugin.extraJvmArgs
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: use tools new conf.d feature
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13151
To uns
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Decouple AspectJ config from
gwt-plugin.extraJvmArgs
..
Patch Set 2: Verified
Verified two use-cases:
* regular build - don't override "gwt
Alon Bar-Lev has posted comments on this change.
Change subject: tools: added rpm to hypervisors sosreport
..
Patch Set 2: (1 inline comment)
File src/__main__.py
Line 539:
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use tools new conf.d feature
..
Patch Set 1: Verified; No score
--
To view, visit http://gerrit.ovirt.org/13151
To unsubscribe, visit http://gerrit.ovi
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use tools new conf.d feature
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/13151
To unsubscribe, visit http://gerrit.ovirt.org/set
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Enable column resizing in Network main tab
..
Patch Set 1:
Need to give all Network table columns explicit explicit width defined in PX
units, will su
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Fix VM/Template General form
..
webadmin: Fix VM/Template General form
This patch fixes the problem when VM/Template General
form displays obs
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Fix VM/Template General form
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12980
To unsubscribe, visit
Vojtech Szocs has abandoned this change.
Change subject: webadmin,userportal: Listener cleanup in
UiCommandButtonDefinition
..
Patch Set 1: Abandoned
Abandoning this patch since all important changes already made its way in vi
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Listener cleanup in
UiCommandButtonDefinition
..
Patch Set 1:
Thanks Einav, indeed all important changes are already merged via patch
[htt
Gilad Chaplik has posted comments on this change.
Change subject: engine: test for AddVdsCommand
..
Patch Set 5: (2 inline comments)
File
backend/manager/modules/bll/src/mai
Sandro Bonazzola has posted comments on this change.
Change subject: tools: added rpm to hypervisors sosreport
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13169
To unsubscribe, visit http://gerrit.ovirt.o
Sandro Bonazzola has uploaded a new change for review.
Change subject: tools: added rpm to hypervisors sosreport
..
tools: added rpm to hypervisors sosreport
Provides information about rpms installed on hypervisors.
Change-Id:
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Remove maxTextLength for Users main tab columns
..
webadmin: Remove maxTextLength for Users main tab columns
In Users main tab, removed maxTex
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Remove maxTextLength for Users main tab columns
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12676
To
Omer Frenkel has posted comments on this change.
Change subject: gluster: Use brick server for advanced details
..
Patch Set 4: (2 inline comments)
File
backend/manager/modu
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Remove maxTextLength for Users main tab columns
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12676
To unsubscribe, visit http://g
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix invalid CSS comment
..
webadmin,userportal: Fix invalid CSS comment
CSS comments should follow /* Comment */ syntax.
Even thou
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Fix invalid CSS comment
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11626
To unsubscribe,
Alexander Wels has posted comments on this change.
Change subject: webadmin,userportal: Fix invalid CSS comment
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11626
To
Alexander Wels has posted comments on this change.
Change subject: webadmin,userportal: Remove '__gwt_historyFrame' iframe
..
Patch Set 1:
Looks like the dependencies is now broken for some reason?
--
To view, visit http://ger
Omer Frenkel has posted comments on this change.
Change subject: gluster: improved gluster audit log util
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/dal
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Fix FindBugs warning in ImportVmModel
..
webadmin: Fix FindBugs warning in ImportVmModel
In ImportVmModel.init() method, 'dataCenter' referenc
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Fix FindBugs warning in ImportVmModel
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12711
To unsubscri
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix FindBugs warning in AbstractActionTable
..
webadmin,userportal: Fix FindBugs warning in AbstractActionTable
FindBugs reports a
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Fix FindBugs warning in AbstractActionTable
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated parsing of the tasks
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/13131
To unsubscribe, visit http://gerrit.ovirt.org/sett
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated parsing of the tasks
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13131
To unsubsc
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated parsing of the tasks
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13131
To unsub
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Updated parsing of the tasks
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13131
To uns
Sandro Bonazzola has abandoned this change.
Change subject: packaging: changed psql parser in
engine-upgrade.getCompensations
..
Patch Set 4: Abandoned
Merged in http://gerrit.ovirt.org/#/c/13131/6
--
To view, visit http://ge
Muli Salem has uploaded a new change for review.
Change subject: webadmin: Alternative Installation Address (2)
..
webadmin: Alternative Installation Address (2)
This patch adds support for the above feature when adding
a new ho
Muli Salem has uploaded a new change for review.
Change subject: engine: Alternative Installation Address (1)
..
engine: Alternative Installation Address (1)
This patch adds support to specifying an alternative
address for host
Juan Hernandez has posted comments on this change.
Change subject: packaging: changed psql parser in
engine-upgrade.getCompensations
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Sharad Mishra has posted comments on this change.
Change subject: engine: Set mnt_option, vfsType for glusterfs.
..
Patch Set 1:
Allon, I agree with your approach. Can you indicate what needs to change to
enable AdvancedNFSOpt
Allon Mureinik has posted comments on this change.
Change subject: Allow creating ISO domain on localfs
..
Patch Set 3:
Hi Mark,
Sorry for the clattered review, but a few more issues I've noticed:
In
org.ovirt.engine.core.bll
Omer Frenkel has posted comments on this change.
Change subject: core: on handing over a VM mark it as MigratingTo
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13040
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: core: on handing over a VM mark it as MigratingTo
..
Patch Set 2: (2 inline comments)
File
backend/manager/modu
Allon Mureinik has posted comments on this change.
Change subject: Allow creating ISO domain on localfs
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/bll/s
Michael Kublin has posted comments on this change.
Change subject: core: when running initVdsOnUp inActive domain can be selected
as master
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
The pat
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated parsing of the async tasks
..
Patch Set 5: Looks good to me, but someone else must approve
Finally! no extra code, thanks!
--
To view, visit h
Liron Ar has posted comments on this change.
Change subject: core: when running initVdsOnUp inActive domain can be selected
as master
..
Patch Set 3: (1 inline comment)
File
Michael Kublin has posted comments on this change.
Change subject: core: remove read lock of template being exported
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
...
1 - 100 of 180 matches
Mail list logo
