Alon Bar-Lev has uploaded a new change for review.
Change subject: host-deploy: cleanup: Redundant nullcheck of vdsByUniqueId
......................................................................
host-deploy: cleanup: Redundant nullcheck of vdsByUniqueId
Change-Id: Idd6454026bfa210c382d1e20d5c69dec7d11c104
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/13186/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
index 02a190a..c3a2edb 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
@@ -366,8 +366,10 @@
/**
* looping foreach VDS found with similar hostnames and change
to each one to available hostname
*/
- if (vdsByUniqueId == null
- || (vdsByUniqueId != null &&
!vds_byHostName.getId().equals(vdsByUniqueId.getId()))) {
+ if (
+ vdsByUniqueId == null ||
+ !vds_byHostName.getId().equals(vdsByUniqueId.getId())
+ ) {
boolean unique = false;
String try_host_name = "";
for (int i = lastIteratedIndex; i <= 100; i++,
lastIteratedIndex = i) {
--
To view, visit http://gerrit.ovirt.org/13186
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd6454026bfa210c382d1e20d5c69dec7d11c104
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
