Maor Lipchuk has posted comments on this change. Change subject: core: Removed the unused GetImageByImageIdQuery ......................................................................
Patch Set 1: (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskStorageListModel.java Line 52: searchableListModel.setItems((ArrayList<StorageDomain>) ((VdcQueryReturnValue) returnValue).getReturnValue()); Line 53: } Line 54: }; Line 55: Line 56: GetStorageDomainsByImageIdParameters getImageByImageIdParameters = Perhaps the parameter name should also be changed from getImageByImageIdParameters to GetStorageDomainsByImageIdParameters Line 57: new GetStorageDomainsByImageIdParameters(diskImage.getImageId()); Line 58: getImageByImageIdParameters.setRefresh(getIsQueryFirstTime()); Line 59: Line 60: Frontend.RunQuery(VdcQueryType.GetStorageDomainsByImageId, getImageByImageIdParameters, _asyncQuery); -- To view, visit http://gerrit.ovirt.org/13138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee84d3e8c903fc9a9cfd6144e8c44af06d04c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
