Michael Kublin has posted comments on this change.
Change subject: core: when running initVdsOnUp inActive domain can be selected
as master
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
The patch will cause for reconstructs rush from host auto-recovery.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 299: && dbStorageDomain.getStorageDomainType()
== StorageDomainType.Data) {
Line 300: if (dbStorageDomain.getStatus() ==
StorageDomainStatus.Active
Line 301: || dbStorageDomain.getStatus() ==
StorageDomainStatus.Unknown) {
Line 302: newMaster = dbStorageDomain;
Line 303: break;
otherwise it will be a first what difference? I don't see importance for order
when domains marked as InActive. But I have another problem
Line 304: } else if
(selectInactiveWhenNoActiveUnknownDomains && newMaster == null
Line 305: && dbStorageDomain.getStatus() ==
StorageDomainStatus.InActive) {
Line 306: // if the found domain is inactive, we
don't break to continue and look for
Line 307: // active/unknown domain.
--
To view, visit http://gerrit.ovirt.org/13160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9031e2fe0afc161c1a3acdddc9b1e7a58626a159
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
