Hello ofri masad,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/13172

to review the following change.

Change subject: core: Fix for VmBase
......................................................................

core: Fix for VmBase

Fix for patch: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54
Removed 'final' from disk list to allow RPC Serialization.

Change-Id: Id3aa95b2c93fb9cd3cc737f88b8a9ac970d42ba3
Signed-off-by: Ofri Masad <oma...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/13172/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
index 8023f2a..4cf0e9f 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
@@ -30,7 +30,7 @@
 public class VmBase extends IVdcQueryable implements BusinessEntity<Guid> {
     private static final long serialVersionUID = 1078548170257965614L;
     private ArrayList<DiskImage> images;
-    private final ArrayList<DiskImage> diskList = new ArrayList<DiskImage>();
+    private ArrayList<DiskImage> diskList = new ArrayList<DiskImage>();
     private List<VmNetworkInterface> interfaces;
     private Map<Guid, VmDevice> managedDeviceMap = new HashMap<Guid, 
VmDevice>();
     private List<VmDevice> unmanagedDeviceList = new ArrayList<VmDevice>();


--
To view, visit http://gerrit.ovirt.org/13172
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3aa95b2c93fb9cd3cc737f88b8a9ac970d42ba3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to