Doron Fediuck has posted comments on this change. Change subject: engine: use autoclose to clean up vdsdeploy ......................................................................
Patch Set 1: Looks good to me, but someone else must approve I agree there is an issue or at least unconvinced there is no issue with the existing code. The above answers Laszlo got are not what I'd expect to see here, and I can only hope the reviewer will not repeat it. Having said the above, I understand the need to use a destructor even when Java-philosophy claims otherwise. So what I'd do to is still use the destructor, while ensuring not to wait for such a long time for other threads. So for the potential of the code being used you will still have it behaving well. -- To view, visit http://gerrit.ovirt.org/13090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43338f9d2d5bfb36c220f1fd19810f8c7436a543 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
