Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Decouple AspectJ config from gwt-plugin.extraJvmArgs ......................................................................
webadmin,userportal: Decouple AspectJ config from gwt-plugin.extraJvmArgs Some people might run into problems when trying to build WebAdmin or UserPortal (e.g. OutOfMemoryError) and therefore need to adjust gwt-maven-plugin JVM args. Overriding "gwt-plugin.extraJvmArgs" directly is not safe, as it also contains AspectJ load-time weaving configuration (used to prevent GWT compiler from pruning certain classes). This patch includes two changes: 1. Move AspectJ-related configuration out of "gwt-plugin.extraJvmArgs", directly into gwt-maven-plugin's extraJvmArgs config element. 2. Increase MaxPermSize from 256M to 512M With this patch, people should be able to override "gwt-plugin.extraJvmArgs" directly, without having to edit pom.xml file. Change-Id: I1761efcec5197121ca97fca3a7f56aa5f1718495 Signed-off-by: Vojtech Szocs <vsz...@redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1761efcec5197121ca97fca3a7f56aa5f1718495 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
