Sandro Bonazzola has posted comments on this change.
Change subject: packaging: changed psql execution environment
..
Patch Set 1: I would prefer that you didn't submit this
I'll update all the calls to psql as alourie suggeste
Sharad Mishra has posted comments on this change.
Change subject: core: Add GlusterFS support to AsyncDataProvider
..
Patch Set 12: (1 inline comment)
File
frontend/webadmin
Sharad Mishra has posted comments on this change.
Change subject: api: Add support for GlusterFS in api.
..
Patch Set 11: (1 inline comment)
Commit Message
Line 5: CommitDate
Sharad Mishra has posted comments on this change.
Change subject: core: Update StoragePoolValidator test to test GlusterFS.
..
Patch Set 12: (2 inline comments)
File
backend
Sharad Mishra has posted comments on this change.
Change subject: core: Adding compatibility version support for GlusterFS.
..
Patch Set 11: (1 inline comment)
Once the patchset is reviewed and approved. I will squash it into a
Alexander Wels has uploaded a new change for review.
Change subject: userportal: fix memory leak when VM selected
..
userportal: fix memory leak when VM selected
- Fixed a slow memory leak when selecting a VM.
Change-Id: Ibea56
Juan Hernandez has submitted this change and it was merged.
Change subject: tools: Use JBoss modules instead of class path
..
tools: Use JBoss modules instead of class path
Currently in order to run the tools we build the class
Juan Hernandez has posted comments on this change.
Change subject: tools: Use JBoss modules instead of class path
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Add jxpath as commons-configuration dep
..
core: Add jxpath as commons-configuration dep
The commons-configuration module provided by JBoss AS do
Juan Hernandez has posted comments on this change.
Change subject: core: Add jxpath as commons-configuration dep
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous ack and verification.
--
To view,
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Add JBoss modules for libraries
..
core: Add JBoss modules for libraries
This patch creates JBoss modules for the common, compat, dal, utils,
too
Juan Hernandez has posted comments on this change.
Change subject: core: Add JBoss modules for libraries
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view, visit h
Liron Aravot has uploaded a new change for review.
Change subject: core : ImportVm - not all disks are actually copied
..
core : ImportVm - not all disks are actually copied
When importing a vm, lists of disk ids and image ids a
Doron Fediuck has submitted this change and it was merged.
Change subject: core: simplify VDSGroup.equals()
..
core: simplify VDSGroup.equals()
Instead of manually doing a null-safe comparison for each VDSGroup
object, use Obje
Doron Fediuck has posted comments on this change.
Change subject: core: simplify VDSGroup.equals()
..
Patch Set 2: Verified; Looks good to me, approved
Rebased.
--
To view, visit http://gerrit.ovirt.org/12206
To unsubscribe, v
Doron Fediuck has posted comments on this change.
Change subject: core: simplify VDSGroup.equals()
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12206
To unsubscribe, visit http://gerrit.o
Doron Fediuck has posted comments on this change.
Change subject: core: Fix sql syntax for quota
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12289
To unsubscribe, vi
Juan Hernandez has posted comments on this change.
Change subject: engine-iso-uploader - notify the user for started upload process
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Sandro Bonazzola has posted comments on this change.
Change subject: engine-iso-uploader - notify the user for started upload process
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12295
To unsubscribe, visi
Sandro Bonazzola has uploaded a new change for review.
Change subject: engine-iso-uploader - notify the user for started upload process
..
engine-iso-uploader - notify the user for started upload process
In upload_to_storage_dom
Tal Nisan has posted comments on this change.
Change subject: core: Extract SD validations from ImagesHandler
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12249
To un
Tal Nisan has posted comments on this change.
Change subject: core: VmRunHandler: snapshot check on diskless VMs
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12246
To
Tal Nisan has posted comments on this change.
Change subject: core: Fix log modifiers in PropretyInfo
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12258
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: engine: Removing opening of global transaction from endAction
..
Patch Set 1:
Michael, I don't think we disagree about the essence of this change (which is
pos
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Show data centers and their clusters based
on configured cluster service
..
Patch Set 5: (6 inline comments)
Tal Nisan has posted comments on this change.
Change subject: core: VmRunHandler: correct check for disk images
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12247
To unsubscribe, visit ht
Tal Nisan has posted comments on this change.
Change subject: build: NlsCheck - unwrap else clause
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12250
To unsubscribe, visit http://gerrit.o
Tal Nisan has posted comments on this change.
Change subject: build: NlsCheck - proper inner class
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12251
To unsubscribe, visit http://gerrit.o
Tal Nisan has posted comments on this change.
Change subject: webadmin: Remove useless null check
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12252
To unsubscribe, visit http://gerrit.ov
Tal Nisan has posted comments on this change.
Change subject: core: Remove PropertyCompat
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12257
To unsubscribe, visit http://gerrit.ovirt.org/
Tal Nisan has posted comments on this change.
Change subject: core: PropertyInfo method name
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12259
To unsubscribe, visit http://gerrit.ovirt.o
Tal Nisan has posted comments on this change.
Change subject: core: Clean up Version.OpEquality
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
File
backend/m
Tal Nisan has posted comments on this change.
Change subject: core: Clean up exception in AuditLogDirectorTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12264
To unsubscribe, visit htt
Oved Ourfali has uploaded a new change for review.
Change subject: GetDiskByDiskId query support for user-level API
..
GetDiskByDiskId query support for user-level API
This patch adds support for the GetDiskByDiskId query for th
Keith Robertson has posted comments on this change.
Change subject: engine-iso-uploader - small usage's output change
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12288
To unsub
Keith Robertson has submitted this change and it was merged.
Change subject: engine-iso-uploader - small usage's output change
..
engine-iso-uploader - small usage's output change
The usage printed to the screen now says that u
ofri masad has uploaded a new change for review.
Change subject: core: Fix sql syntax for quota
..
core: Fix sql syntax for quota
calculateAllVdsGroupUsage function was fixed to be compatible with lower
postgres versions (verifi
Sandro Bonazzola has posted comments on this change.
Change subject: engine-iso-uploader - small usage's output change
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12288
To unsubscribe, visit http://gerrit
Sandro Bonazzola has uploaded a new change for review.
Change subject: engine-iso-uploader - small usage's output change
..
engine-iso-uploader - small usage's output change
The usage printed to the screen now says that upload o
Michael Kublin has posted comments on this change.
Change subject: core: fix redundant storage server conn in db
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
..
Yaniv Bronhaim has posted comments on this change.
Change subject: Add detailed note to user when password validation fails by
using engine-config
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12153
To uns
Roy Golan has posted comments on this change.
Change subject: core: refactor - separate VdsUpdateRuntime responsibilities
..
Patch Set 1: (1 inline comment)
File
backend/man
Roy Golan has posted comments on this change.
Change subject: core: create a data structure for all Runtime updates logics
..
Patch Set 1: (1 inline comment)
File
backend/ma
Noam Slomianko has uploaded a new change for review.
Change subject: webadmin: Linit selection of datacenters in new quota
..
webadmin: Linit selection of datacenters in new quota
when creating new quota from the datacenter_quot
Roy Golan has posted comments on this change.
Change subject: core: create a data structure for all Runtime updates logics
..
Patch Set 1: (2 inline comments)
File
backend/m
Michael Kublin has posted comments on this change.
Change subject: engine: Removing opening of global transaction from endAction
..
Patch Set 1:
Allon,
First, @Deprecated - I marked part of such commands and reason was they not
Arik Hadas has posted comments on this change.
Change subject: core: create a data structure for all Runtime updates logics
..
Patch Set 1: (2 inline comments)
File
backend/
Arik Hadas has posted comments on this change.
Change subject: core: refactor - separate VdsUpdateRuntime responsibilities
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Michal Skrivanek has posted comments on this change.
Change subject: webadmin: Show warning, if VM provides no disk for export,
snapshot, template
..
Patch Set 1: (1 inline comment)
please rephrase
...
Allon Mureinik has posted comments on this change.
Change subject: core: add line number to logged statements
..
Patch Set 1:
I think this is a great change, but there are too many voices against it.
I'd suggest abandoning thi
Allon Mureinik has posted comments on this change.
Change subject: engine: Removing opening of global transaction from endAction
..
Patch Set 1:
!Michael
Re: scenarios that will break - all of the above. These aren't just the
Michael Pasternak has posted comments on this change.
Change subject: codegen: make /export preserved name
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12283
To unsubscribe, vis
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: make /export preserved name
..
codegen: make /export preserved name
Change-Id: I96072237f92f9d2cfc56ac576e1b3102388e9fca
Signed-off-by: Mic
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up Version.OpEquality
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/compat/s
Libor Spevak has uploaded a new change for review.
Change subject: webadmin: Show warning, if VM provides no disk for export,
snapshot, template
..
webadmin: Show warning, if VM provides no disk for export, snapshot, template
N
Eli Mesika has posted comments on this change.
Change subject: core:we are fencing a host when putting it in ...
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12284
To unsubscribe, visit http://gerrit.ovirt
Eli Mesika has uploaded a new change for review.
Change subject: core:we are fencing a host when putting it in ...
..
core:we are fencing a host when putting it in ...
we are fencing a host when putting it in maintenance after f
Greg Padgett has posted comments on this change.
Change subject: core: simplify VDSGroup.equals()
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12206
To unsubscribe, visit http://gerrit.ovirt.org/settings
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Move dependencies to a JBoss module
..
packaging: Move dependencies to a JBoss module
Currently we package dependencies as .jar files in the
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move dependencies to a JBoss module
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11686
To unsubscribe, visit
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move dependencies to a JBoss module
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/11686
To unsubscribe, visit http://gerrit.ovir
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move dependencies to a JBoss module
..
Patch Set 4:
Rebased.
--
To view, visit http://gerrit.ovirt.org/11686
To unsubscribe, visit http://gerrit.ovi
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: add timestamps to engine-db-install logs
..
packaging: add timestamps to engine-db-install logs
Added new function logmsg that add a timesta
Juan Hernandez has posted comments on this change.
Change subject: packaging: add timestamps to engine-db-install logs
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To
Juan Hernandez has posted comments on this change.
Change subject: packaging: add timestamps to engine-db-install logs
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12238
To unsubscribe, v
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: changed psql parser in
engine-upgrade.getCompensations
..
packaging: changed psql parser in engine-upgrade.getCompensations
In engine-upgra
Juan Hernandez has posted comments on this change.
Change subject: packaging: changed psql parser in
engine-upgrade.getCompensations
..
Patch Set 4: Verified; Looks good to me, approved
Merging based on previous acks and verif
Juan Hernandez has posted comments on this change.
Change subject: packaging: changed psql parser in
engine-upgrade.getCompensations
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12220
To
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: allow importing ISO domain on setup, exports.d
support
..
packaging: allow importing ISO domain on setup, exports.d support
moved the priva
Juan Hernandez has posted comments on this change.
Change subject: packaging: allow importing ISO domain on setup, exports.d
support
..
Patch Set 8: Verified
Merging based on previous acks and verification.
--
To view, visit
Juan Hernandez has posted comments on this change.
Change subject: packaging: allow importing ISO domain on setup, exports.d
support
..
Patch Set 8: Looks good to me, approved
Merging based on previous acks and verification.
Juan Hernandez has posted comments on this change.
Change subject: packaging: allow importing ISO domain on setup, exports.d
support
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11556
To
Michael Pasternak has uploaded a new change for review.
Change subject: codegen: make /export preserved name
..
codegen: make /export preserved name
Change-Id: I96072237f92f9d2cfc56ac576e1b3102388e9fca
Signed-off-by: Michael Pas
Muli Salem has submitted this change and it was merged.
Change subject: core: Send Bonded Network with bonding
..
core: Send Bonded Network with bonding
This patch locates the underlying interface
that the changed network is de
Muli Salem has posted comments on this change.
Change subject: core: Send Bonded Network with bonding
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12060
To unsubscribe, visit ht
Muli Salem has submitted this change and it was merged.
Change subject: core: Refactor SetupNetworksVdsCommand
..
core: Refactor SetupNetworksVdsCommand
This patch refactors the block of code that
generate networks that were mo
Muli Salem has posted comments on this change.
Change subject: core: Refactor SetupNetworksVdsCommand
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12059
To unsubscribe, visit ht
Muli Salem has posted comments on this change.
Change subject: core: Send Bonded Network with bonding
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12060
To unsubscribe, visit ht
Muli Salem has posted comments on this change.
Change subject: core: Refactor SetupNetworksVdsCommand
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12059
To unsubscribe, visit ht
Vered Volansky has posted comments on this change.
Change subject: core: PropertyInfo method name
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12259
To unsubscribe, v
Vered Volansky has posted comments on this change.
Change subject: core: Clean up Version.OpEquality
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Please consider my comment first.
...
Alex Lourie has posted comments on this change.
Change subject: packaging: changed psql parser in
engine-upgrade.getCompensations
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Alex Lourie has posted comments on this change.
Change subject: packaging: changed psql execution environment
..
Patch Set 1:
The problem with this patch is that sometimes psql is run directly with
execCmd; in this case the en
Alex Lourie has posted comments on this change.
Change subject: packaging: changed tasks polling in engine-upgrade
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12177
Vered Volansky has posted comments on this change.
Change subject: core: AddVmFromSnapshot - avoid early end method run
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Please fix commit messa
Vered Volansky has posted comments on this change.
Change subject: core: Remove PropertyCompat
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12257
To unsubscribe, visi
Alex Lourie has posted comments on this change.
Change subject: packaging: add timestamps to engine-db-install logs
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12238
Michael Kublin has posted comments on this change.
Change subject: engine: Removing opening of global transaction from endAction
..
Patch Set 1:
Allon, I also know how to use eclipse, and how to find all inherited methods
from
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove PropertyCompat
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12257
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove PropertyCompat
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/compat/src/main/
Omer Frenkel has posted comments on this change.
Change subject: core: refactor - separate VdsUpdateRuntime responsibilities
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: create a data structure for all Runtime updates logics
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Updated the skipTests instruction for mvn build
..
packaging: Updated the skipTests instruction for mvn build
Replaced maven.test.skip=true
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated the skipTests instruction for mvn build
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verification.
Allon Mureinik has posted comments on this change.
Change subject: core: refactor - separate VdsUpdateRuntime responsibilities
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated the skipTests instruction for mvn build
..
Patch Set 1: Looks good to me, approved
Speed is very important for the rpm-quick target, as it is
Maor Lipchuk has posted comments on this change.
Change subject: core: VmRunHandler: simplify isInternal evaluation
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12248
To unsubscribe, visi
Libor Spevak has posted comments on this change.
Change subject: webdmin: Restrict destination host parameter for administrator
roles
..
Patch Set 5:
Currently checking just destinationVdsId parameter sent from the RunOnce dia
Maor Lipchuk has posted comments on this change.
Change subject: core: DbFacadeUtils basic Java cleanup
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12263
To unsubscribe, visit http://ger
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix NPE in AuditLogableBaseTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12265
To unsubscribe, visit http://gerr
1 - 100 of 232 matches
Mail list logo
