Allon Mureinik has posted comments on this change. Change subject: engine: Removing opening of global transaction from endAction ......................................................................
Patch Set 1: !Michael Re: scenarios that will break - all of the above. These aren't just the inheriting methods, these are all the methods that have more than one DAO call. Why would they break? because if you kill the engine after the first one auto-commits, you will leave the system in a non consistent state. The direction should be the opposite - if you think it's OK to commit between each two DAO calls, you should show why. Re: @NonTransactional - ack, my bad. Re: deprecated commands - this means we are not adding improvements, not that we can just break them at will (otherwise, we would just remove them). -- To view, visit http://gerrit.ovirt.org/12010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c114d4d3072b8b9213d73cf8e155d98c5fbef6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
