Allon Mureinik has posted comments on this change. Change subject: engine: Removing opening of global transaction from endAction ......................................................................
Patch Set 1: Michael, I don't think we disagree about the essence of this change (which is positive), just on the way to get there. "not all scenarios will be broken." By definition, behaviour will change - if this is not broken, it should be explained why this is OK. Currently, no explanation is given. Re: the example of LiveMoveDisks - agree, that should be fixed. The fact that it is broken is no reason to break other flows too. "all daos operation which are belongs to same flow should be under same transaction, but this should be done by code writer and not by framework." Agree. But this shouldn't be done /after/ the framework behaviour has changed, but together with it. No more, no less. Re: deprecated code - disagree. MoveVM/MoveTemplate still exist as REST operations, and other commands extend them and use their endXYZ methods. Sure, they should be killed off (hence, deprecated, as you mentioned), but this does not mean we can just break them without care. -- To view, visit http://gerrit.ovirt.org/12010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c114d4d3072b8b9213d73cf8e155d98c5fbef6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
