Eli Mesika has uploaded a new change for review.

Change subject: core:we are fencing a host when putting it in ...
......................................................................

core:we are fencing a host when putting it in ...

we are fencing a host when putting it in maintenance after failed reinstall.

Block Host from being re-installed if it is in the non-operational
state.

Change-Id: Ib4b5fa23de6db22bf075712b256b8652a692df0e
Signed-off-by: Eli Mesika <emes...@redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=906389
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/84/12284/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
index f408602..412522b 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
@@ -38,6 +38,11 @@
             retValue = false;
         } else if (isOvirtReInstallOrUpgrade()) {
             String isoFile = getParameters().getoVirtIsoFile();
+            // Block re-install on non-operational Host
+            if  (getVds().getStatus() == VDSStatus.NonOperational) {
+                
addCanDoActionMessage(VdcBllMessages.VDS_CANNOT_INSTALL_STATUS_ILLEGAL);
+                retValue = false;
+            }
             if (!isIsoFileValid(isoFile)) {
                 
addCanDoActionMessage(VdcBllMessages.VDS_CANNOT_INSTALL_MISSING_IMAGE_FILE);
                 retValue = false;


--
To view, visit http://gerrit.ovirt.org/12284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4b5fa23de6db22bf075712b256b8652a692df0e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to