Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Show data centers and their clusters based
on configured cluster service
......................................................................
Patch Set 5: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStoragePoolsByClusterServiceQuery.java
Line 1: /**
remove redundant comment
Line 2: *
Line 3: */
Line 4: package org.ovirt.engine.core.bll.storage;
Line 5:
Line 5:
Line 6: import org.ovirt.engine.core.bll.QueriesCommandBase;
Line 7: import
org.ovirt.engine.core.common.queries.GetStoragePoolsByClusterServiceParameters;
Line 8:
Line 9: /**
remove redundant comment
Line 10: *
Line 11: */
Line 12: public class GetStoragePoolsByClusterServiceQuery<P extends
GetStoragePoolsByClusterServiceParameters> extends QueriesCommandBase<P> {
Line 13:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDataCentersWithPermittedActionOnClustersParameters.java
Line 5: private static final long serialVersionUID = -6927484770394754188L;
Line 6:
Line 7: boolean supportsVirtService;
Line 8: boolean supportsGlusterService;
Line 9:
add default constructor (needed for GWT RPC serialization in web mode)
Line 10: public boolean isSupportsVirtService() {
Line 11: return supportsVirtService;
Line 12: }
Line 13:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStoragePoolsByClusterServiceParameters.java
Line 9: private static final long serialVersionUID = -4118891133830586523L;
Line 10:
Line 11: boolean supportsVirtService;
Line 12: boolean supportsGlusterService;
Line 13:
add default constructor (needed for GWT RPC serialization in web mode)
Line 14: public boolean isSupportsVirtService() {
Line 15: return supportsVirtService;
Line 16: }
Line 17:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 599: }
Line 600:
Line 601: final ArrayList<VDSGroup> list =
(ArrayList<VDSGroup>) source;
Line 602: final ArrayList<VDSGroup> filteredList = new
ArrayList<VDSGroup>();
Line 603: for(VDSGroup cluster : list) {
consider extracting the filter logic to an helper method (it's the same as in
GetClustersWithPermittedAction)
Line 604: if ((supportsVirtService &&
cluster.supportsVirtService()) || (supportsGlusterService &&
cluster.supportsGlusterService())) {
Line 605: filteredList.add(cluster);
Line 606: }
Line 607: }
Line 1330: {
Line 1331: if (source != null)
Line 1332: {
Line 1333: ArrayList<VDSGroup> list = (ArrayList<VDSGroup>)
source;
Line 1334: final ArrayList<VDSGroup> filteredList = new
ArrayList<VDSGroup>();
same filtering...
Line 1335: for(VDSGroup cluster : list) {
Line 1336: if ((supportsVirtService &&
cluster.supportsVirtService()) || (supportsGlusterService &&
cluster.supportsGlusterService())) {
Line 1337: filteredList.add(cluster);
Line 1338: }
--
To view, visit http://gerrit.ovirt.org/11395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb63c7e2addf525bb527d94694a8dfc752d69154
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
