Michal Skrivanek has posted comments on this change.

Change subject: webadmin: Show warning, if VM provides no disk for export, 
snapshot, template
......................................................................


Patch Set 1: (1 inline comment)

please rephrase....

....................................................
File 
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
Line 101: 
Line 102:     @DefaultMessage("Shared disk(s): {0} will not be part of the 
exported snapshot.")
Line 103:     String disksWillNotBePartOfTheExportedVMSnapshot(String diskList);
Line 104: 
Line 105:     @DefaultMessage("No disk will be part of the exported virtual 
machine.")
sounds weird to me....sort of implies there are some disks and you are not 
exporting any of them. But this is a diskless VM
Line 106:     String noDiskWillBePartOfTheExportedVM();
Line 107: 
Line 108:     @DefaultMessage("No disk will be part of the exported template.")
Line 109:     String noDiskWillBePartOfTheExportedTemplate();


--
To view, visit http://gerrit.ovirt.org/12286
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I339da4bcab18799603caeafb0171fdcea262ec29
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to