Vered Volansky has posted comments on this change. Change subject: core: AddVmFromSnapshot - avoid early end method run ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Please fix commit message when you rebase. .................................................... Commit Message Line 6: Line 7: core: AddVmFromSnapshot - avoid early end method run Line 8: Line 9: When adding vm as a clone of snapshot, the vm id should be set as Line 10: the entity id for the child commands parameters - this prevent a /prevent/prevents Line 11: situation in which the end method is called too early. Line 12: Line 13: NOTE: seems like the MoveOrCopyImageGroupParameters class might be Line 14: re-factored so that in a case of given ContainerId, it will be set as the -- To view, visit http://gerrit.ovirt.org/12267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a536cb3c530fd9caa0b121830481604c0558d53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
