Allon Mureinik has posted comments on this change.
Change subject: core: simplify VDSGroup.equals()
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12206
To unsubscribe,
静 黎 has uploaded a new change for review.
Change subject: engine:solve the language switch fuction failure problem
..
engine:solve the language switch fuction failure problem
Modify the judgment statement at change the locale ev
Omer Frenkel has posted comments on this change.
Change subject: engine: skip CPU checks while updating gluster cluster
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12218
To unsubscribe,
Tomas Jelinek has posted comments on this change.
Change subject: userportal: Optimization fixes
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12213
To unsubscribe, vi
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Fix text aligned not properly for long strings.
..
packaging: Fix text aligned not properly for long strings.
During the upgrade process we
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix text aligned not properly for long strings.
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks and verification.
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix text aligned not properly for long strings.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12194
To unsubsc
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Don't send events on startup
..
tools: Don't send events on startup
Currently the event notifier sends all the pending events during
startup. Th
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Don't send events on startup
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11483
To unsubscribe, visit h
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Fix text aligned not properly for long strings.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Don't send events on startup
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11483
To unsubscribe, visit http://gerr
Yair Zaslavsky has posted comments on this change.
Change subject: Move fkvalidator.sh to tools/dbutils
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12172
To unsubscribe, visit http://ge
Selvasundaram has uploaded a new change for review.
Change subject: engine: Gluster hook content query
..
engine: Gluster hook content query
Fetch and return the specific gluster hook content from db.
Change-Id: Ie24d11
Yair Zaslavsky has posted comments on this change.
Change subject: core:sorting of VMs changes during refresh
..
Patch Set 1: Looks good to me, approved
Acking this, per Eli's explanation
--
To view, visit http://gerrit.ovirt.
Yaniv Bronhaim has posted comments on this change.
Change subject: Add detailed note to user when password validation fails by
using engine-config
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12153
To uns
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix dao tests not to print lookup error
..
core: Fix dao tests not to print lookup error
Although this does not break tests, seeing an exception
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix dao tests not to print lookup error
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12176
To unsubscrib
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Changes to MockEJBStrategyRule
..
core: Changes to MockEJBStrategyRule
The following patch introduces the following changes:
1. Gives the ability
Yair Zaslavsky has posted comments on this change.
Change subject: core: Changes to MockEJBStrategyRule
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12186
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix dao tests not to print lookup error
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12176
To unsubscrib
Yair Zaslavsky has posted comments on this change.
Change subject: core: Changes to MockEJBStrategyRule
..
Patch Set 2: Verified; Looks good to me, approved
Followed Allon's comment.
Merging.
--
To view, visit http://gerrit.ov
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove JBoss specific logging from bll
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12168
To unsubscribe, visit ht
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove unused JARs from bll's pom.xml
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12167
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: Add detailed note to user when password validation fails by
using engine-config
..
Patch Set 2: Looks good to me, approved
Thanks for your comment, Steve.
--
Kanagaraj M has uploaded a new change for review.
Change subject: engine: skip CPU checks while updating gluster cluster
..
engine: skip CPU checks while updating gluster cluster
While updating a cluster which supports gluster(d
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Webadmin won't let user login in second tab
..
Patch Set 8: Looks good to me, approved
After discussion with Gilad,
Approving this.
--
To view, visit
Chris Morrissey has posted comments on this change.
Change subject: restapi: add /disks sub-collection to /storagedomain resource
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
I've tested this patch
Chris Morrissey has posted comments on this change.
Change subject: [WIP] webadmin: UI plugin dialog API improved
..
Patch Set 1:
I'm definitely looking forward to hiding the hard coded close button as that's
the last piece we
Chris Morrissey has posted comments on this change.
Change subject: [WIP] webadmin: UI plugin dialog API improved
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Code looks good. I pulled it down and g
Alon Bar-Lev has posted comments on this change.
Change subject: engine: check if vds exists with same name
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12192
To unsu
Roy Golan has uploaded a new change for review.
Change subject: core: set SRC VM to MigratingTo when DST is ready
..
core: set SRC VM to MigratingTo when DST is ready
Today a migrating VM which is ready to run on the DST is set
Tal Nisan has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
Very minor suggesti
Ravi Nori has posted comments on this change.
Change subject: restapi : Add /clusters sub-collection under
/datacenters/xxx(#674521)
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/11618
To unsubscribe, visi
Chris Morrissey has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 3: (2 inline comments)
Will submit small fixes for the two comments in patch set 4.
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Use X-UA-Compatible with IE=edge
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
(1 inline comment)
Verified on IE1
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Updated getEngineVersion functionality
..
packaging: Updated getEngineVersion functionality
If we use the getEngineVersion code on upgrades
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated getEngineVersion functionality
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous approval and verification.
--
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated getEngineVersion functionality
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12211
To unsubscribe, vis
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated getEngineVersion functionality
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12211
To unsubscribe, visit http://gerrit.ovir
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix text aligned not properly for long strings.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Alex Lourie has posted comments on this change.
Change subject: packaging: Fix text aligned not properly for long strings.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12194
To unsubscribe, visit http://ge
Alex Lourie has posted comments on this change.
Change subject: packaging: Fix text aligned not properly for long strings.
..
Patch Set 1: (1 inline comment)
File packaging/f
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated getEngineVersion functionality
..
Patch Set 1: Looks good to me, but someone else must approve
Please verify.
--
To view, visit http://gerri
Alexander Wels has posted comments on this change.
Change subject: webadmin,userportal: Use X-UA-Compatible with IE=edge
..
Patch Set 1:
We have to make sure this doesn't get lost when we merge the caching patches,
as they tak
Einav Cohen has posted comments on this change.
Change subject: webadmin,userportal: Use X-UA-Compatible with IE=edge
..
Patch Set 1:
Vojtech, did you happen to verify that the drag-and-drop behavior in the Host
network config
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: add qouta mode check in consume storage
..
engine: add qouta mode check in consume storage
Problem: When qouta mode is set to audit, error "no q
Doron Fediuck has posted comments on this change.
Change subject: engine: add qouta mode check in consume storage
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12049
To unsubscri
Doron Fediuck has posted comments on this change.
Change subject: engine: add qouta mode check in consume storage
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12049
To unsubscribe, visit
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Use X-UA-Compatible with IE=edge
..
webadmin,userportal: Use X-UA-Compatible with IE=edge
There might be cases when WebAdmin or UserPortal
Laszlo Hornyak has posted comments on this change.
Change subject: engine: check if vds exists with same name
..
Patch Set 1: No score
(1 inline comment)
File
backend/manag
Alexander Wels has posted comments on this change.
Change subject: userportal: Optimization fixes
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12213
To unsubscribe, v
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Updated getEngineVersion functionality
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1221
Juan Hernandez has abandoned this change.
Change subject: core: Install utils tests jar
..
Patch Set 1: Abandoned
This is not needed, the tests jar is generated automatically for any artifact
with jar packaging, as the maven-j
Daniel Erez has posted comments on this change.
Change subject: webadmin: create cluster hangs
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11507
To unsubscribe, visit http://gerrit.ovirt
Liron Aravot has uploaded a new change for review.
Change subject: core : increment pool master version only if there's new master
..
core : increment pool master version only if there's new master
When incrementing the pool mas
Ravi Nori has posted comments on this change.
Change subject: cli: ovirt-shell does not exit when using -f option(#854519)
..
Patch Set 1: (1 inline comment)
Ok thanks
Commi
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Updated getEngineVersion functionality
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Fix text aligned not properly for long strings.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I think that using t
Michael Pasternak has posted comments on this change.
Change subject: cli: ovirt-shell does not exit when using -f option(#854519)
..
Patch Set 1: (3 inline comments)
ravi,
well done!, the thing is that shell currently writes
Liron Aravot has posted comments on this change.
Change subject: engine: add qouta mode check in consume storage
..
Patch Set 2:
no objection..that was only a suggestion :)
--
To view, visit http://gerrit.ovirt.org/12049
To un
Doron Fediuck has posted comments on this change.
Change subject: engine: add qouta mode check in consume storage
..
Patch Set 2:
Liron,
see Noam's reply.
If no objections will merge tomorrow.
--
To view, visit http://gerrit.o
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Optimization fixes
..
Patch Set 1:
> Fixed a problem when Basic view item selection was not retained after
> subsequent data refresh
This is alread
Alex Lourie has posted comments on this change.
Change subject: core: Install utils tests jar
..
Patch Set 1:
Alisa
I'm having a trouble building master upstream with the following error:
Failed to execute goal on project dal
Doron Fediuck has posted comments on this change.
Change subject: core: Make connection timeout configurable
..
Patch Set 10: I would prefer that you didn't submit this
Sorry guys,
This is just for temporary logistics.
I want t
Alissa Bonas has posted comments on this change.
Change subject: core: Install utils tests jar
..
Patch Set 1:
Could you please elaborate what problem are you seeing and what this patch
fixes?
This patch was merged a while ago
Doron Fediuck has posted comments on this change.
Change subject: core: Remove rmw-war
..
Patch Set 1: Looks good to me, but someone else must approve
I'm fine with it- you have my ACK.
Just adding Moran to verify there are no
Vojtech Szocs has uploaded a new change for review.
Change subject: userportal: Optimization fixes
..
userportal: Optimization fixes
1. Fixed a problem when Basic view item selection
was not retained after subsequent data ref
Ravi Nori has posted comments on this change.
Change subject: cli: ovirt-shell does not exit when using -f option(#854519)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12212
To unsubscribe, visit http://ge
Ravi Nori has uploaded a new change for review.
Change subject: cli: ovirt-shell does not exit when using -f option(#854519)
..
cli: ovirt-shell does not exit when using -f option(#854519)
ovirt-shell does not exit when -f optio
Maor Lipchuk has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 3: Looks good to me, but someone else must approve
See inline comments
--
To view, vis
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated getEngineVersion functionality
..
packaging: Updated getEngineVersion functionality
If we use the getEngineVersion code on upgrades from
versio
ofri masad has posted comments on this change.
Change subject: webadmin: Add details to general Cluster sub-tab
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/11726
To unsubscribe, visit http://gerrit.ovirt
Maor Lipchuk has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 3: (1 inline comment)
File
backen
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal : Events sorting - oldest first
..
userportal : Events sorting - oldest first
Incorrect sorting of events in user portal.
The events are not
Gilad Chaplik has posted comments on this change.
Change subject: userportal : Events sorting - oldest first
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12181
To unsubscribe, visit http:
Ravi Nori has posted comments on this change.
Change subject: userportal : Events sorting - oldest first
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/12181
To unsubscribe, visit http://gerrit.ovirt.org/set
Martin Beták has posted comments on this change.
Change subject: engine: Correct error message on diskless VM run
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12210
To unsubscribe, visit http://gerrit.ovir
Martin Beták has uploaded a new change for review.
Change subject: engine: Correct error message on diskless VM run
..
engine: Correct error message on diskless VM run
Display correct error message when a diskless VM is run on a
ofri masad has posted comments on this change.
Change subject: webadmin: Add details to general Cluster sub-tab
..
Patch Set 10: (2 inline comments)
File
frontend/webadmin/m
Ravi Nori has posted comments on this change.
Change subject: userportal : Events sorting - oldest first
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/12181
To unsubscribe, visit http://gerrit.ovirt.org/set
Juan Hernandez has uploaded a new change for review.
Change subject: core: Install utils tests jar
..
core: Install utils tests jar
This is needed by the DAL tests since commit 6c8007.
Change-Id: Ibd952c0a5672d07aec2a61fb2786f1
Yair Zaslavsky has posted comments on this change.
Change subject: core: Maven plugin to generate JBoss modules
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12072
To unsubscribe, visit ht
Alissa Bonas has posted comments on this change.
Change subject: core: fix redundant storage server conn in db
..
Patch Set 6: Verified
just rebased...
--
To view, visit http://gerrit.ovirt.org/11936
To unsubscribe, visit http
Alissa Bonas has posted comments on this change.
Change subject: core: fix redundant storage server conn in db
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/11936
To unsubscribe, visit http://gerrit.ovirt.o
Alissa Bonas has posted comments on this change.
Change subject: core: fix redundant storage server conn in db
..
Patch Set 4: (2 inline comments)
File
backend/manager/modul
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11047
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Looks OK to me
Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: Change move to quota enforcing mode message
..
webadmin: Change move to quota enforcing mode message
The message presented when moving the DC
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Change move to quota enforcing mode message
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12163
To uns
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Change move to quota enforcing mode message
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12163
To unsubscribe,
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fix Quota accounting for move disk
..
core: Fix Quota accounting for move disk
When moving a disk without changing a quota the quota check is not
Gilad Chaplik has posted comments on this change.
Change subject: core: Fix Quota accounting for move disk
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12159
To unsubscribe, vis
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix text aligned not properly for long strings.
..
Patch Set 1: Looks good to me, but someone else must approve
Please verify.
--
To view, visit htt
Ravi Nori has abandoned this change.
Change subject: tools : manage-domains messages should be more clear
..
Patch Set 3: Abandoned
moved to master
--
To view, visit http://gerrit.ovirt.org/11992
To unsubscribe, visit http://g
Gilad Chaplik has posted comments on this change.
Change subject: engine : Webadmin won't let user login in second tab
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: engine-setup avoid traceback when loading iso
..
packaging: engine-setup avoid traceback when loading iso
In engine-setup, _loadFilesToIsoDo
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-setup avoid traceback when loading iso
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12207
To unsubscri
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: release 3.2.0.10-1
..
cli: release 3.2.0.10-1
Change-Id: Idfe3920a2563b1d23e915e68b81e56ccfe73fe08
Signed-off-by: Michael Pasternak
---
M Make
Michael Pasternak has posted comments on this change.
Change subject: cli: release 3.2.0.10-1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12208
To unsubscribe, visit http://ger
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-setup avoid traceback when loading iso
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12207
To unsubscribe, visit http:/
1 - 100 of 215 matches
Mail list logo
