Martin Beták has uploaded a new change for review. Change subject: engine: Correct error message on diskless VM run ......................................................................
engine: Correct error message on diskless VM run Display correct error message when a diskless VM is run on a cluster with no valid hosts instead of Internal Engine Error. VmRunHandler.canRunVm now checks if there are available hosts in the cluster even if the VM has no disks. Change-Id: I8b346b341cbe3a84b32dff32d14b12aa80c17881 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908397 Signed-off-by: Martin Betak <mbe...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/12210/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java index d853b76..b656fe8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java @@ -170,21 +170,21 @@ if (retValue && isStatelessVm && !hasSpaceForSnapshots(vm, message)) { return false; } - - retValue = retValue == false ? retValue : vdsSelector.canFindVdsToRunOn(message, false); - - /** - * only if can do action ok then check with actions matrix that status is valid for this - * action - */ - if (retValue - && !VdcActionUtils.CanExecute(Arrays.asList(vm), VM.class, - VdcActionType.RunVm)) { - retValue = false; - message.add(VdcBllMessages.ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL.toString()); - } } } + + retValue = retValue == false ? retValue : vdsSelector.canFindVdsToRunOn(message, false); + + /** + * only if can do action ok then check with actions matrix that status is valid for this + * action + */ + if (retValue + && !VdcActionUtils.CanExecute(Arrays.asList(vm), VM.class, + VdcActionType.RunVm)) { + retValue = false; + message.add(VdcBllMessages.ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL.toString()); + } } } } -- To view, visit http://gerrit.ovirt.org/12210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b346b341cbe3a84b32dff32d14b12aa80c17881 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbe...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
