Alex Lourie has posted comments on this change.
Change subject: packaging: Fix text aligned not properly for long strings.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 574: logging.debug("Post script completed successfully")
Line 575:
Line 576: def runFunc(funcList, dispString):
Line 577: sys.stdout.write("%s..." % dispString)
Line 578: sys.stdout.flush()
not really. the problem is not that the message text overlaps certain border;
the problem is that the corresponding "Done" or "Error" notification is not
aligned.
Line 579: if len(dispString) > 69:
Line 580: # Split by lines (\n), and work with last part (may be empty
string):
Line 581: dispString = dispString.split('\n')[-1]
Line 582:
--
To view, visit http://gerrit.ovirt.org/12194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id242e8a247ae720b3aeb37f40004241dfc3920de
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
