Chris Morrissey has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
......................................................................
Patch Set 3: (2 inline comments)
Will submit small fixes for the two comments in patch set 4.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 846:
Line 847: # Register disk error
Line 848: ACTION_TYPE_FAILED_UNSUPPORTED_DISK_STORAGE_TYPE=Cannot register disk
${diskId}. Its storage type ${storageType} is not supported.
Line 849: ACTION_TYPE_FAILED_STORAGE_DOMAIN_UNAVAILABLE=Cannot register disk
${diskId} on storage domain ${domainId} as it is unavailable.
Line 850: ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_UNSUPPORTED=Disks may only be
registered from a data storage domain. The storage domain {$domainId} is type
{$domainType}.
Removed.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResourceTest.java
Line 85: return setUpStatisticalEntityExpectations(entity);
Line 86: }
Line 87: static org.ovirt.engine.core.common.businessentities.Disk
setUpStatisticalEntityExpectations(DiskImage entity) {
Line 88: entity.setReadRate(1);
Line 89: entity.setReadRate(2);
Yep.
Line 90: entity.setReadLatency(3.0);
Line 91: entity.setWriteLatency(4.0);
Line 92: entity.setFlushLatency(5.0);
Line 93: return entity;
--
To view, visit http://gerrit.ovirt.org/11783
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82de498fd9a8e25ed9e1dc5776f2fdf0c35b46da
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Chris Morrissey <cmorr...@netapp.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Chris Morrissey <cmorr...@netapp.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
