Liron Aravot has uploaded a new change for review.
Change subject: core : increment pool master version only if there's new master
......................................................................
core : increment pool master version only if there's new master
When incrementing the pool master version, it should be incremented only
when there is a new master otherwise we might not be able to use the
pool again/perform unneeded reconstructs.
Incrementing the version always can be hazardous, an example is when we
have a pool with one domain which we deactivate, master version will be
incremented and then we won't be able to perform ConnectStoragePool (as
we will have now different master version in engine compared to vdsm),
reconstruct will also fail as there are no active domains and we won't
be able to have the pool operational again.
Change-Id: Ib292802ee2b7feeb95656d492f75dde549350c48
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/12214/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
index 2f80993..508a558 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
@@ -288,10 +288,10 @@
return null;
}
});
+ updateStoragePoolMasterDomainVersionInDiffTransaction();
} else {
_isLastMaster = true;
}
- updateStoragePoolMasterDomainVersionInDiffTransaction();
}
}
--
To view, visit http://gerrit.ovirt.org/12214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib292802ee2b7feeb95656d492f75dde549350c48
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
