Roy Golan has uploaded a new change for review.
Change subject: core: set SRC VM to MigratingTo when DST is ready
......................................................................
core: set SRC VM to MigratingTo when DST is ready
Today a migrating VM which is ready to run on the DST is set to UKNOWN
at the SRC.
Sometimes admins can view a migrating VM transiting to UKNOWN and this
is a pure UX for it being confusing and puzzling and can drag the admin
to try to take actions trying to find out whats wrong.
The new behaviour is to set the VM to MigratingTo. The rest of the
process i.e, stop monitoring that VM on SRC and so on is left unchanged.
note: NonResponding treatment (@See VdsEventListener.vdsNotResponding)
is immediately terminating the current monitoring cycle and happens
*before* the VM state transition so there is no race between the two flows.
Change-Id: Ia1e6a4d606b5e1b3a21044f7c7c03cdd00e548d5
Signed-off-by: Roy Golan <rgo...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/12216/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
index ac3dc4c..b77245f 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
@@ -250,6 +250,7 @@
}
public void InternalSetVmStatus(VM vm, final VMStatus status, final
VmExitStatus exitStaus, final String exitMessage) {
+ log.infoFormat("Setting VM {0} {1} to status {2}", vm.getName(),
vm.getId(), status);
vm.setStatus(status);
vm.setExitStatus(exitStaus);
vm.setExitMessage(exitMessage);
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
index ab7fc46..4cc7f38 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
@@ -1523,8 +1523,7 @@
if (vmToRemove.getStatus() == VMStatus.MigratingFrom) {
isInMigration = true;
vmToRemove.setRunOnVds(vmToRemove.getmigrating_to_vds());
- log.infoFormat("Setting VM {0} {1} to status unknown",
vmToRemove.getName(), vmToRemove.getId());
- ResourceManager.getInstance().InternalSetVmStatus(vmToRemove,
VMStatus.Unknown);
+ ResourceManager.getInstance().InternalSetVmStatus(vmToRemove,
VMStatus.MigratingTo);
addVmDynamicToList(vmToRemove.getDynamicData());
addVmStatisticsToList(vmToRemove.getStatisticsData());
addVmInterfaceStatisticsToList(vmToRemove.getInterfaces());
--
To view, visit http://gerrit.ovirt.org/12216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1e6a4d606b5e1b3a21044f7c7c03cdd00e548d5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
